Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Jun 2012 18:22:50 +0000 (UTC)
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org
Subject:   svn commit: r237408 - vendor-sys/acpica/dist/source/compiler
Message-ID:  <201206211822.q5LIMoKs028955@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jkim
Date: Thu Jun 21 18:22:50 2012
New Revision: 237408
URL: http://svn.freebsd.org/changeset/base/237408

Log:
  Fix "comparison is always true due to limited range of data type" warning
  from GCC in the base system.  Note this patch was submitted upstream and it
  will appear in the next ACPICA release.
  
  Discussed with:	Moore, Robert (robert dot moore at intel dot com)

Modified:
  vendor-sys/acpica/dist/source/compiler/aslsupport.l

Modified: vendor-sys/acpica/dist/source/compiler/aslsupport.l
==============================================================================
--- vendor-sys/acpica/dist/source/compiler/aslsupport.l	Thu Jun 21 16:53:52 2012	(r237407)
+++ vendor-sys/acpica/dist/source/compiler/aslsupport.l	Thu Jun 21 18:22:50 2012	(r237408)
@@ -92,7 +92,7 @@ static void
 AslDoLineDirective (
     void)
 {
-    UINT8                   c;
+    int                     c;
     char                    *Token;
     UINT32                  LineNumber;
     char                    *Filename;
@@ -103,7 +103,7 @@ AslDoLineDirective (
 
     Gbl_LineBufPtr = Gbl_CurrentLineBuffer;
 
-    while ((c = (UINT8) input()) != '\n' && c != EOF)
+    while ((c = input()) != '\n' && c != EOF)
     {
         *Gbl_LineBufPtr = c;
         Gbl_LineBufPtr++;
@@ -430,8 +430,8 @@ static char
 AslDoComment (
     void)
 {
-    char                c;
-    char                c1 = 0;
+    int                 c;
+    int                 c1 = 0;
 
 
     AslInsertLineBuffer ('/');
@@ -441,7 +441,7 @@ loop:
 
     /* Eat chars until end-of-comment */
 
-    while ((c = (char) input()) != '*' && c != EOF)
+    while ((c = input()) != '*' && c != EOF)
     {
         AslInsertLineBuffer (c);
         c1 = c;
@@ -468,7 +468,7 @@ loop:
 
     AslInsertLineBuffer (c);
 
-    if ((c1 = (char) input()) != '/' && c1 != EOF)
+    if ((c1 = input()) != '/' && c1 != EOF)
     {
         unput(c1);
         goto loop;
@@ -511,13 +511,13 @@ static char
 AslDoCommentType2 (
     void)
 {
-    char                c;
+    int                 c;
 
 
     AslInsertLineBuffer ('/');
     AslInsertLineBuffer ('/');
 
-    while ((c = (char) input()) != '\n' && c != EOF)
+    while ((c = input()) != '\n' && c != EOF)
     {
         AslInsertLineBuffer (c);
     }
@@ -553,7 +553,7 @@ AslDoStringLiteral (
     char                *StringBuffer = MsgBuffer;
     char                *EndBuffer = MsgBuffer + ASL_MSG_BUFFER_SIZE;
     char                *CleanString;
-    char                StringChar;
+    int                 StringChar;
     UINT32              State = ASL_NORMAL_CHAR;
     UINT32              i = 0;
     UINT8               Digit;
@@ -566,7 +566,7 @@ AslDoStringLiteral (
      * source line buffer.
      */
     AslInsertLineBuffer ('\"');
-    while ((StringChar = (char) input()) != EOF)
+    while ((StringChar = input()) != EOF)
     {
         AslInsertLineBuffer (StringChar);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206211822.q5LIMoKs028955>