Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Sep 2018 19:53:46 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r480070 - in head/converters: lua-iconv lua51-iconv
Message-ID:  <201809181953.w8IJrkLs028895@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste (src committer)
Date: Tue Sep 18 19:53:46 2018
New Revision: 480070
URL: https://svnweb.freebsd.org/changeset/ports/480070

Log:
  converters/lua*-iconv: enable -fPIC on arm64 and i386, for lld
  
  Shared objects should be built as PIC, and lld enforces this by default.
  Add aarch64 and i386 cases to the existing set of per-arch CFLAGS, and
  remove the BROKEN_aarch64.
  
  Approved by:	portmgr (lld blanket)
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/converters/lua-iconv/Makefile
  head/converters/lua51-iconv/Makefile

Modified: head/converters/lua-iconv/Makefile
==============================================================================
--- head/converters/lua-iconv/Makefile	Tue Sep 18 19:20:17 2018	(r480069)
+++ head/converters/lua-iconv/Makefile	Tue Sep 18 19:53:46 2018	(r480070)
@@ -3,7 +3,7 @@
 
 PORTNAME=	iconv
 PORTVERSION=	7
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	converters
 MASTER_SITES=	GHC
 PKGNAMEPREFIX=	${LUA_PKGNAMEPREFIX}
@@ -15,8 +15,6 @@ COMMENT=	Iconv binding for Lua 5
 LICENSE=	MIT
 LICENSE_FILE=	${WRKSRC}/COPYING
 
-BROKEN_aarch64=		fails to link: can't create dynamic relocation R_AARCH64_ABS64 against local symbol in readonly segment
-
 USES=		pkgconfig iconv lua
 
 USE_GITHUB=	yes
@@ -27,7 +25,9 @@ PLIST_FILES=	${LUA_MODLIBDIR}/iconv.so
 CFLAGS+=	`pkgconf --cflags lua-${LUA_VER}` -I${LOCALBASE}/include
 MAKE_ARGS=	LUABIN=${LUA_CMD} CFLAGS="${CFLAGS}"
 LDFLAGS+=	-shared ${ICONV_LIB} -L${LOCALBASE}/lib
+CFLAGS_aarch64=	-fPIC
 CFLAGS_amd64=	-fPIC
+CFLAGS_i386=	-fPIC
 
 do-install:
 	@${MKDIR} ${STAGEDIR}${LUA_MODLIBDIR}

Modified: head/converters/lua51-iconv/Makefile
==============================================================================
--- head/converters/lua51-iconv/Makefile	Tue Sep 18 19:20:17 2018	(r480069)
+++ head/converters/lua51-iconv/Makefile	Tue Sep 18 19:53:46 2018	(r480070)
@@ -3,7 +3,7 @@
 
 PORTNAME=	iconv
 PORTVERSION=	7
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	converters
 MASTER_SITES=	GHC
 PKGNAMEPREFIX=	${LUA_PKGNAMEPREFIX}
@@ -12,8 +12,6 @@ DISTNAME=	lua-${PORTNAME}-${PORTVERSION}
 MAINTAINER=	feld@FreeBSD.org
 COMMENT=	Iconv binding for Lua 5
 
-BROKEN_aarch64=		fails to link: can't create dynamic relocation R_AARCH64_ABS64 against local symbol in readonly segment defined in iconv.lo
-
 USES=		pkgconfig iconv lua:51
 
 USE_GITHUB=	yes
@@ -24,7 +22,9 @@ PLIST_FILES=	%%LUA_MODLIBDIR%%/iconv.so
 CFLAGS+=	`pkgconf --cflags lua-${LUA_VER}` -I${LOCALBASE}/include
 MAKE_ARGS=	LUABIN=${LUA_CMD} CFLAGS="${CFLAGS}"
 LDFLAGS=	-shared ${ICONV_LIB} -L${LOCALBASE}/lib
+CFLAGS_aarch64=	-fPIC
 CFLAGS_amd64=	-fPIC
+CFLAGS_i386=	-fPIC
 
 do-install:
 	@${MKDIR} ${STAGEDIR}${LUA_MODLIBDIR}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809181953.w8IJrkLs028895>