From owner-freebsd-current Fri Mar 29 3:34: 9 2002 Delivered-To: freebsd-current@freebsd.org Received: from mailout05.sul.t-online.com (mailout05.sul.t-online.com [194.25.134.82]) by hub.freebsd.org (Postfix) with ESMTP id 05B9437B417; Fri, 29 Mar 2002 03:34:05 -0800 (PST) Received: from fwd04.sul.t-online.de by mailout05.sul.t-online.com with smtp id 16qudt-0006gb-04; Fri, 29 Mar 2002 12:34:01 +0100 Received: from Magelan.Leidinger.net (520065502893-0001@[80.131.107.178]) by fmrl04.sul.t-online.com with esmtp id 16qudh-0T53gWC; Fri, 29 Mar 2002 12:33:49 +0100 Received: from Leidinger.net (netchild@localhost [127.0.0.1]) by Magelan.Leidinger.net (8.12.2/8.12.2) with ESMTP id g2TBXch8003045; Fri, 29 Mar 2002 12:33:42 +0100 (CET) (envelope-from netchild@Leidinger.net) Message-Id: <200203291133.g2TBXch8003045@Magelan.Leidinger.net> Date: Fri, 29 Mar 2002 12:33:37 +0100 (CET) From: Alexander Leidinger Subject: ICC userland patch (was: Re: cvs commit: ports/lang Makefile ports/lang/icc Makefile distinfo pkg-comment pkg-descr pkg-plist ports/lang/icc/files patch-include) To: winter@jurai.net Cc: jmallett@FreeBSD.ORG, green@FreeBSD.ORG, sw@anthologeek.net, freebsd-current@FreeBSD.ORG In-Reply-To: <200203291044.g2TAi6h8000665@Magelan.Leidinger.net> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Sender: 520065502893-0001@t-dialin.net Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 29 Mär, An: winter@jurai.net wrote: >> My patches to src/share/mk/ are here: >> >> ftp://ftp.jurai.net/users/winter/icc.mk.diff Not tested, feel free to point out some typo's: http://www.leidinger.net/FreeBSD/icc.mk.diff It's based upon your patch and addresses the points below. > My review of your patch: > bsd.lib.mk: > - Shouldn't ICC_PICFLAG be encapsulated withhin '.if !defined(ICC_PICFLAC)' > like PICFLAG is? > sys.mk: > - Have a look at the '#ICC' line. > - You've commented bsd.cpu.mk out. We should add USE_ICC stuff there too. Bye, Alexander. -- Secret hacker rule #11: hackers read manuals. http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message