From owner-freebsd-hackers@freebsd.org Tue Oct 16 20:04:20 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EBED410E0421 for ; Tue, 16 Oct 2018 20:04:19 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 54C5A7D4A0 for ; Tue, 16 Oct 2018 20:04:19 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-it1-x144.google.com with SMTP id c85-v6so11506766itd.1 for ; Tue, 16 Oct 2018 13:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=qmumv9Yp9z30KBVBz7np+2DcRfp9LQGJa8gUt8QCx6M=; b=lv6+H70Z9jyUqlfwpnIzKFGhC3TZ6df4v40tE7H0uVHqsNK9onyaOdvPsKgtS/QqAa QiwXCrs8TaoVm2PN4ZhErwP7s1+OJyYTLvKIMx7csgs118LMFq3HOZOfpZJAcI1FLciN 5NZCL+dOrHf//DYvcI8PEnYF31+JuP6B64/q1+2tRMavv3SSAoveFP+4z3N+MjUHFyR1 c1+RH8/FQJvTh2RcWNNzOlpEJwatbolAb51nagtBc5kRBxVZ19pYz9A0NmOqGcJoK8VP vi2F9jBluh5BchlgA7jRXF6f7vLTQkSxvM1GFUgXMNMI/sEDq2rWdqvFhL0B6u5mUhg7 AWhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=qmumv9Yp9z30KBVBz7np+2DcRfp9LQGJa8gUt8QCx6M=; b=AnZWjE5fQH2dNV2TrGjaIF1u+cihkpmwPn852keot5XEKJ38hTruaoEzlddgQMaU0B 9Duve9qYn8Ls84BwDggwUPa0mH8+BvSJH7REI+RwFs85BmRAgmRAY/RZBlQlyrTJQ6+m iupR6Btg8rOjZa/f494YTveRInyWbbco8cBaHfeETpEjOYTSqBluWtwzpheftsDmTlOA ru0rSxViPNOBkwerNmAhzRjp5EGyINas3Luh4f0zjT00/ueFR5bEbEgcBliCgmHN19sf qfkNjDMzEa6uUB5ukzr4ZbELDX0JRtwZ6y92wydicGO3st571hZr1mCo3d6hsuyLBOkv z7nQ== X-Gm-Message-State: ABuFfojw807D5HHibY33afGxEteKEih0VwslgCid2mWeQ/WRyFV57y0s lp3Hdiim/W+DpdmOHE7Go52yvxafTi8= X-Google-Smtp-Source: ACcGV62YeUWMWr+Dvpe8jpLHD67Ab33BR8srfNf4KdOMoaWvI40L/cvmicp2acPDoaF/sU9k86iEaw== X-Received: by 2002:a24:2993:: with SMTP id p141-v6mr17129690itp.119.1539720257782; Tue, 16 Oct 2018 13:04:17 -0700 (PDT) Received: from raichu (toroon0560w-lp130-09-70-52-226-56.dsl.bell.ca. [70.52.226.56]) by smtp.gmail.com with ESMTPSA id c26-v6sm5060359itd.18.2018.10.16.13.04.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 13:04:16 -0700 (PDT) Sender: Mark Johnston Date: Tue, 16 Oct 2018 16:04:14 -0400 From: Mark Johnston To: "Bjoern A. Zeeb" Cc: freebsd-hackers@freebsd.org Subject: Re: [CFT] capsicum patches for rtsol(8) and rtsold(8) Message-ID: <20181016200414.GD5066@raichu> References: <20181015194212.GA2751@spy> <20181016165308.GB5066@raichu> <86D87437-BD34-489A-87B7-33F1089080EE@lists.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86D87437-BD34-489A-87B7-33F1089080EE@lists.zabbadoz.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 20:04:20 -0000 On Tue, Oct 16, 2018 at 06:29:49PM +0000, Bjoern A. Zeeb wrote: > On 16 Oct 2018, at 16:53, Mark Johnston wrote: > > > On Tue, Oct 16, 2018 at 04:06:43PM +0000, Bjoern A. Zeeb wrote: > >> On 15 Oct 2018, at 19:42, Mark Johnston wrote: > >> > >>> https://people.freebsd.org/~markj/patches/rtsold_capsicum.diff > >> > >> (0) the git rename doesn’t really work when applying the diff with > >> FreeBSD’s patch so the mv has to be done manually > >> > >> (1) the rtsol Makefile also needs cap_syslog and util to link to > >> otherwise rtsold.c has unresolved symbols > >> > >> (2) rtsol seem to have worked when manually invoked; > >> /etc/resolv.conf > >> was created (I had rm’ed it) and the 3 nameserver lines > >> re-appeared; > >> sorry can’t test the search string here > >> > >> (3) rtsold crashes: > > > > Thanks. I made some last-minute changes and forgot to retest, of > > course. :( > > > > I uploaded a new patch which should fix all of these issues - could > > you > > give it a try? > > With the old and new patch: > > root@i386-a3-carp:/usr/src/sbin/rtsol # rtsol vtnet0 > failed to run script: Invalid argument > > Hadn’t noticed that before. That's a cosmetic bug. I uploaded a new patch which should fix it. > Also on a running system: > > root@i386-a3-carp:/ # rm /etc/resolv.conf > root@i386-a3-carp:/ # cat /etc/resolv.conf > cat: /etc/resolv.conf: No such file or directory > root@i386-a3-carp:/ # sh /etc/rc.d/rtsold restart > Stopping rtsold. > Waiting for PIDS: 1047. > Starting rtsold. > root@i386-a3-carp:/ # cat /etc/resolv.conf > cat: /etc/resolv.conf: No such file or directory resolvconf -a will only update /etc/resolv.conf if the info in /var/run/resolvconf/interfaces/vtnet0 has changed, I believe. Try deleting that file too, and then try running rtsol. > After a reboot: > > root@i386-a3-carp:~ # ps ax | grep rts > 372 - SCs 0:00.01 /usr/sbin/rtsold -a > 375 - Ss 0:00.01 rtsold: system.syslog (rtsold) > 376 - S 0:00.00 rtsold: rtsold.script (rtsold) > 693 u0 R+ 0:00.01 grep rts > root@i386-a3-carp:~ # cat /etc/resolv.conf > # Generated by resolvconf > nameserver .. > > root@i386-a3-carp:~ # rtsol vtnet0 > failed to run script: Invalid argument > root@i386-a3-carp:~ # sh /etc/rc.d/rtsold restart > Stopping rtsold. > Waiting for PIDS: 372. > Starting rtsold. > Oct 16 18:28:33 i386-a3-carp rtsold[734]: failed to run > script: Invalid argument > > > /bz