From owner-cvs-src Fri Feb 28 9:16:59 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3951037B401; Fri, 28 Feb 2003 09:16:57 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 94B3643F93; Fri, 28 Feb 2003 09:16:50 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (smmsp@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.7/8.12.7) with ESMTP id h1SHGodh066822; Fri, 28 Feb 2003 09:16:50 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.7/8.12.7/Submit) id h1SHGoeS066821; Fri, 28 Feb 2003 09:16:50 -0800 (PST) Date: Fri, 28 Feb 2003 09:16:50 -0800 From: "David O'Brien" To: Ruslan Ermilov Cc: Bruce Evans , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/share/man/man5 Makefile style.Makefile.5 Message-ID: <20030228171650.GA66554@dragon.nuxi.com> Reply-To: obrien@freebsd.org References: <200302262043.h1QKhlN4009440@repoman.freebsd.org> <20030228170548.GA60899@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030228170548.GA60899@sunbay.com> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Feb 28, 2003 at 07:05:48PM +0200, Ruslan Ermilov wrote: > On Wed, Feb 26, 2003 at 12:43:47PM -0800, David E. O'Brien wrote: > > obrien 2003/02/26 12:43:47 PST > > > > Modified files: > > share/man/man5 Makefile > > Added files: > > share/man/man5 style.Makefile.5 > > Log: > > FreeBSD Makefile style guide. > > > > Approved by: TRB > > > > Revision Changes Path > > 1.48 +1 -1 src/share/man/man5/Makefile > > 1.1 +178 -0 src/share/man/man5/style.Makefile.5 (new) > > > I seem to have missed a copy for review too. A post-commit > review, part #1, is attached. As I said I asked you key points. Some of the wording is almost straight out of your emails. :-) I did have it reviewed for mdoc issues, by a committer I don't want to drag into any potential bike sheds. > --- style.Makefile.5 26 Feb 2003 20:43:47 -0000 1.1 > +++ style.Makefile.5 28 Feb 2003 16:50:08 -0000 > @@ -9,9 +9,6 @@ > .\" 2. Redistributions in binary form must reproduce the above copyright > .\" notice, this list of conditions and the following disclaimer in the > .\" documentation and/or other materials provided with the distribution. > -.\" 3. Neither the name of the author nor the names of any contributors > -.\" may be used to endorse or promote products derived from this software > -.\" without specific prior written permission. Uh, generally you go changing licenses. The rest of the style changes I have no problem making as I totally go with the wind on mdoc-style and usage. Thanks for the diff as I'm "monkey see, monkey do" with mdoc. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message