From owner-svn-src-head@freebsd.org Fri Mar 13 01:27:39 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3AB1F270CF5; Fri, 13 Mar 2020 01:27:39 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48dp3G6LLHz4KsJ; Fri, 13 Mar 2020 01:27:38 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9BEBC2E359; Fri, 13 Mar 2020 01:27:38 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 02D1Rcs4045908; Fri, 13 Mar 2020 01:27:38 GMT (envelope-from jhibbits@FreeBSD.org) Received: (from jhibbits@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 02D1RbRF045905; Fri, 13 Mar 2020 01:27:37 GMT (envelope-from jhibbits@FreeBSD.org) Message-Id: <202003130127.02D1RbRF045905@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jhibbits set sender to jhibbits@FreeBSD.org using -f From: Justin Hibbits Date: Fri, 13 Mar 2020 01:27:37 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r358928 - in head/sys/powerpc: booke powerpc X-SVN-Group: head X-SVN-Commit-Author: jhibbits X-SVN-Commit-Paths: in head/sys/powerpc: booke powerpc X-SVN-Commit-Revision: 358928 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2020 01:27:39 -0000 Author: jhibbits Date: Fri Mar 13 01:27:37 2020 New Revision: 358928 URL: https://svnweb.freebsd.org/changeset/base/358928 Log: powerpc: Simplify _nodrop variants of FPU and vector register saves No need for an extra temporary. It doesn't even help with readability. Suggested by: kib (almost 2 years ago) Modified: head/sys/powerpc/booke/spe.c head/sys/powerpc/powerpc/altivec.c head/sys/powerpc/powerpc/fpu.c Modified: head/sys/powerpc/booke/spe.c ============================================================================== --- head/sys/powerpc/booke/spe.c Fri Mar 13 01:06:08 2020 (r358927) +++ head/sys/powerpc/booke/spe.c Fri Mar 13 01:27:37 2020 (r358928) @@ -183,14 +183,11 @@ save_vec(struct thread *td) void save_vec_nodrop(struct thread *td) { - struct thread *vtd; struct pcb *pcb; int i; - vtd = PCPU_GET(vecthread); - if (td == vtd) { + if (td == PCPU_GET(vecthread)) save_vec_int(td); - } pcb = td->td_pcb; Modified: head/sys/powerpc/powerpc/altivec.c ============================================================================== --- head/sys/powerpc/powerpc/altivec.c Fri Mar 13 01:06:08 2020 (r358927) +++ head/sys/powerpc/powerpc/altivec.c Fri Mar 13 01:27:37 2020 (r358928) @@ -168,12 +168,7 @@ save_vec(struct thread *td) void save_vec_nodrop(struct thread *td) { - struct thread *vtd; - vtd = PCPU_GET(vecthread); - if (td != vtd) { - return; - } - - save_vec_int(td); + if (td == PCPU_GET(vecthread)) + save_vec_int(td); } Modified: head/sys/powerpc/powerpc/fpu.c ============================================================================== --- head/sys/powerpc/powerpc/fpu.c Fri Mar 13 01:06:08 2020 (r358927) +++ head/sys/powerpc/powerpc/fpu.c Fri Mar 13 01:27:37 2020 (r358928) @@ -204,12 +204,7 @@ save_fpu(struct thread *td) void save_fpu_nodrop(struct thread *td) { - struct thread *ftd; - ftd = PCPU_GET(fputhread); - if (td != ftd) { - return; - } - - save_fpu_int(td); + if (td == PCPU_GET(fputhread)) + save_fpu_int(td); }