From owner-svn-src-head@FreeBSD.ORG Fri Sep 17 03:10:41 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0873D1065670 for ; Fri, 17 Sep 2010 03:10:41 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 892938FC0A for ; Fri, 17 Sep 2010 03:10:40 +0000 (UTC) Received: (qmail 23003 invoked by uid 399); 17 Sep 2010 03:10:39 -0000 Received: from localhost (HELO ?192.168.0.142?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 17 Sep 2010 03:10:39 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4C92DC2E.2020602@FreeBSD.org> Date: Thu, 16 Sep 2010 20:10:38 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: "Carlos A. M. dos Santos" References: <201009141804.o8EI45kp088466@svn.freebsd.org> <20100916014404.0409017f@dev.lan.Awfulhak.org> In-Reply-To: X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Brian Somers , Kirk McKusick Subject: Re: svn commit: r212617 - head/sys/ufs/ffs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Sep 2010 03:10:41 -0000 On 9/16/2010 7:29 PM, Carlos A. M. dos Santos wrote: > On Thu, Sep 16, 2010 at 5:44 AM, Brian Somers wrote: >> If INVARIANTS is not defined, the above i++ will not happen. > > Which does not cause any harm, since "i" is a local variable, not used > anywhere else in the function. A picky compiler would complain, > however, that the variable is never read. If 'i' is only ever used in the INVARIANTS case then it should be appropriately wrapped everywhere it appears. While the _current_ situation may be harmless, in the future lack of an appropriate indication of its use may cause a problem. This isn't just a pedantic concern, we had a case like this that broke the build just recently. Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/