Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Apr 2007 04:03:39 +0400
From:      "Andrew Pantyukhin" <infofarmer@FreeBSD.org>
To:        "Martin Wilke" <miwi@freebsd.org>
Cc:        cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: cvs commit: ports/shells Makefile ports/shells/shell-include Makefile distinfo pkg-descr pkg-plist
Message-ID:  <cb5206420704201703o48b03873ma61f59da3a88a2d2@mail.gmail.com>
In-Reply-To: <200704202136.l3KLaagS037676@repoman.freebsd.org>
References:  <200704202136.l3KLaagS037676@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 4/21/07, Martin Wilke <miwi@freebsd.org> wrote:
>   1.1       +39 -0     ports/shells/shell-include/Makefile (new)

How did this file get into the tree? Did a committer have
a look at it? Or was it some kind of an automated commit?

Nothing should enter the tree without a thorough review
by a committer. We can't just give something a quick
glance and let it through. We are responsible for every
line of code we add, change or delete.

I admire you, Martin, for your everlasting energy. But
every time someone stumbles over a subtle bug in the
ports tree and asks me for help, I can't tell him that
our Project is getting untested code just because we're
becoming more active. Every time I see a piece of very
poorly written code in the tree, I can't tell myself
that's the price we have to pay for being the top
package management system in the world.

Please remember we're the ones setting the high
standards for other BSD systems and Linux distros.

Thanks!



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cb5206420704201703o48b03873ma61f59da3a88a2d2>