From owner-cvs-ports@FreeBSD.ORG Sat Apr 21 00:04:08 2007 Return-Path: X-Original-To: cvs-ports@freebsd.org Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 979F416A46C for ; Sat, 21 Apr 2007 00:04:08 +0000 (UTC) (envelope-from infofarmer@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.228]) by mx1.freebsd.org (Postfix) with ESMTP id 0E3B913C4D0 for ; Sat, 21 Apr 2007 00:03:47 +0000 (UTC) (envelope-from infofarmer@gmail.com) Received: by wr-out-0506.google.com with SMTP id 70so1108197wra for ; Fri, 20 Apr 2007 17:03:40 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=HiE6H6MS7Osi6ZY3X4y5IpLH7dRWcoVDlNsrNWkcvd6E2zZLtoOawWJgg+J1T5NGbL/leNhlMuLkgggHmCTC0pkgIm8Xja1eScftHBGrwTC4l6oPP8+8XjcykWfnYbcP3RqB4BDhF20azDmkLdNDucYYhr958sXE4cOE2PcVyjA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=X9w/x8sPflyWueN4je8jy2mpNd8SQHNe7Xm6+4l2V0F+MNCQzsBtKqH17AJa52TqsMYabjl7hPjhtBy8GO2zdfHU6nnKqM4hFloKRTq6DPrGcgMtL8/U0H90bXAyPjg1kulW8fWZAolnN+3UWMevUYsTIEe3HXPpe86F1DkMhak= Received: by 10.114.196.1 with SMTP id t1mr1469728waf.1177113819974; Fri, 20 Apr 2007 17:03:39 -0700 (PDT) Received: by 10.114.194.5 with HTTP; Fri, 20 Apr 2007 17:03:39 -0700 (PDT) Message-ID: Date: Sat, 21 Apr 2007 04:03:39 +0400 From: "Andrew Pantyukhin" Sender: infofarmer@gmail.com To: "Martin Wilke" In-Reply-To: <200704202136.l3KLaagS037676@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200704202136.l3KLaagS037676@repoman.freebsd.org> X-Google-Sender-Auth: 5fa72113db26d31a Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/shells Makefile ports/shells/shell-include Makefile distinfo pkg-descr pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Apr 2007 00:04:08 -0000 On 4/21/07, Martin Wilke wrote: > 1.1 +39 -0 ports/shells/shell-include/Makefile (new) How did this file get into the tree? Did a committer have a look at it? Or was it some kind of an automated commit? Nothing should enter the tree without a thorough review by a committer. We can't just give something a quick glance and let it through. We are responsible for every line of code we add, change or delete. I admire you, Martin, for your everlasting energy. But every time someone stumbles over a subtle bug in the ports tree and asks me for help, I can't tell him that our Project is getting untested code just because we're becoming more active. Every time I see a piece of very poorly written code in the tree, I can't tell myself that's the price we have to pay for being the top package management system in the world. Please remember we're the ones setting the high standards for other BSD systems and Linux distros. Thanks!