Date: Sat, 25 Oct 2008 14:50:28 GMT From: Carlos Santos <unixmania@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/128366: [PATCH] graphics/epdfview: fix dependency on CUPpS and improve configuration Message-ID: <200810251450.m9PEoSJH093599@www.freebsd.org> Resent-Message-ID: <200810251500.m9PF0704007852@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 128366 >Category: ports >Synopsis: [PATCH] graphics/epdfview: fix dependency on CUPpS and improve configuration >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Oct 25 15:00:07 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Carlos Santos >Release: 8-CURRENT/AMD64 >Organization: N.A. >Environment: FreeBSD poacasantos1 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Fri Oct 24 23:44:22 BRST 2008 root@poacasantos1:/usr/obj/usr/src/sys/GENERIC amd64 >Description: If epdfview-0.1.6_6 is built when print/cups-base is installed, it will be linked to libcups.so.2. Removing cups-base afterwards will render epdeview unusable. >How-To-Repeat: - install cups-base - remove epdfview-0.1.6_6, if installed - build epdfview-0.1.6_6 - remove cups-base - try to run epdfview % /usr/local/bin/epdfview /libexec/ld-elf.so.1: Shared object "libcups.so.2" not found, required by "epdfview" >Fix: Apply the attached patch - Makes the dependency on cups a configurable option (default off) - Makes Native Language Support a configurable option (default on) - Bumps PORTREVISION Patch attached with submission follows: diff -dur epdfview.orig/Makefile epdfview/Makefile --- epdfview.orig/Makefile 2008-09-03 21:24:35.000000000 -0300 +++ epdfview/Makefile 2008-10-25 11:54:33.000000000 -0200 @@ -7,7 +7,7 @@ PORTNAME= epdfview PORTVERSION= 0.1.6 -PORTREVISION= 6 +PORTREVISION= 7 CATEGORIES= graphics print gnome MASTER_SITES= http://trac.emma-soft.com/epdfview/chrome/site/releases/ \ LOCAL/chinsan @@ -27,6 +27,18 @@ CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \ LDFLAGS="-L${LOCALBASE}/lib" +OPTIONS= CUPS "Use cups printing system" off \ + NLS "Native language support" on + +.include <bsd.port.pre.mk> + +.if defined(WITH_CUPS) +CONFIGURE_ARGS+=--with-cups +LIB_DEPENDS+= cups.2:${PORTSDIR}/print/cups-base +.else +CONFIGURE_ARGS+=--without-cups +.endif + .if !defined(WITHOUT_NLS) USE_GETTEXT= yes PLIST_SUB+= NLS="" @@ -43,4 +55,4 @@ ${INSTALL_DATA} ${WRKSRC}/data/${PORTNAME}.desktop ${PREFIX}/share/applications/ @-update-desktop-database -.include <bsd.port.mk> +.include <bsd.port.post.mk> Only in epdfview: work >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810251450.m9PEoSJH093599>