Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Aug 2017 15:58:29 -0400
From:      Dan Langille <dan@langille.org>
To:        Mathieu Arnold <mat@FreeBSD.org>
Cc:        Emanuel Haupt <ehaupt@critical.ch>, Dan Langille <dvl@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r448998 - head/net-mgmt/tcpreplay
Message-ID:  <31D6EC55-A634-4176-92E6-8FC1FD456833@langille.org>
In-Reply-To: <e91a3087-d546-cc4b-87f4-ef3e31c717c0@FreeBSD.org>
References:  <201708301932.v7UJW1tH094312@repo.freebsd.org> <a00fd1cd-1e0a-115e-d5d2-d1478a2bea71@critical.ch> <e91a3087-d546-cc4b-87f4-ef3e31c717c0@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> On Aug 30, 2017, at 3:54 PM, Mathieu Arnold <mat@FreeBSD.org> wrote:
>=20
> Le 30/08/2017 =C3=A0 21:47, Emanuel Haupt a =C3=A9crit :
>>=20
>>=20
>> On 30.08.17 21:32, Dan Langille wrote:
>>> Author: dvl
>>> Date: Wed Aug 30 19:32:00 2017
>>> New Revision: 448998
>>> URL: https://svnweb.freebsd.org/changeset/ports/448998
>>>=20
>>> Log:
>>>    Add base/port options for libpcap
>>>       PR:        221923
>>>    Approved by:    ehaupt (maintainer)
>>>=20
>>> Modified:
>>>    head/net-mgmt/tcpreplay/Makefile
>>>=20
>>> Modified: head/net-mgmt/tcpreplay/Makefile
>>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>>>=20
>>> --- head/net-mgmt/tcpreplay/Makefile    Wed Aug 30 19:18:00 2017  =20=

>>> (r448997)
>>> +++ head/net-mgmt/tcpreplay/Makefile    Wed Aug 30 19:32:00 2017  =20=

>>> (r448998)
>>> @@ -4,6 +4,7 @@
>>>   PORTNAME=3D    tcpreplay
>>>   PORTVERSION=3D    4.2.6
>>>   DISTVERSIONPREFIX=3D    v
>>> +PORTREVISION=3D    1
>>>   CATEGORIES=3D    net-mgmt
>>>     MAINTAINER=3D    ehaupt@FreeBSD.org
>>> @@ -26,6 +27,18 @@ CONFIGURE_ARGS=3D  =20
>>> --program-transform-name=3D's|.*\(tcp.*\
>>>     # required when using autogen
>>>   CONFIGURE_ARGS+=3D    --disable-local-libopts =
--disable-libopts-install
>>> +
>>> +OPTIONS_DEFINE=3D    LIBPCAP_BASE LIBPCAP_PORTS
>>> +LIBPCAP_BASE=3D    Build with libpcap from the base OS
>>> +LIBPCAP_PORTS=3D    Build with net/libpcap
>>> +
>>> +OPTIONS_SINGLE=3D    SG1
>>> +OPTIONS_SINGLE=3D    LIBPCAP_BASE LIBPCAP_PORTS
>>> +
>>> +OPTIONS_DEFAULT=3D    LIBPCAP_BASE
>>> +
>>> +LIBPCAP_PORTS_BUILD_DEPENDS=3D    =
${LOCALBASE}/lib/libpcap.a:net/libpcap
>>> +LIBPCAP_PORTS_LIB_DEPENDS=3D    libpcap.so:net/libpcap
>>>     post-patch:
>>>       @${REINPLACE_CMD} -e 's|-Wall -O3||'
>>> ${WRKSRC}/${CONFIGURE_SCRIPT}.ac
>>>=20
>>=20
>> Are you going to add a description for LIBPCAP_BASE and LIBPCAP_PORTS
>> in ports/Mk/bsd.options.desc.mk? Right now the two options have no
>> description.
>=20
> I think it would be faster to add _DESC for the options descriptions =
here.


I see the descriptions in there, but they are not correctly set.  I will =
fix this now.

--=20
Dan Langille - BSDCan / PGCon
dan@langille.org






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?31D6EC55-A634-4176-92E6-8FC1FD456833>