From owner-svn-ports-all@freebsd.org Wed Aug 30 19:58:39 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10F29E09160; Wed, 30 Aug 2017 19:58:39 +0000 (UTC) (envelope-from dan@langille.org) Received: from clavin2.langille.org (clavin2.langille.org [199.233.228.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "clavin.langille.org", Issuer "BSD Cabal Headquarters" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D7E487DB4D; Wed, 30 Aug 2017 19:58:38 +0000 (UTC) (envelope-from dan@langille.org) Received: from (clavin2.int.langille.org (clavin2.int.unixathome.org [10.4.7.7]) (Authenticated sender: hidden) with ESMTPSA id 9630D1F6D7 ; Wed, 30 Aug 2017 19:58:30 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r448998 - head/net-mgmt/tcpreplay From: Dan Langille In-Reply-To: Date: Wed, 30 Aug 2017 15:58:29 -0400 Cc: Emanuel Haupt , Dan Langille , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <31D6EC55-A634-4176-92E6-8FC1FD456833@langille.org> References: <201708301932.v7UJW1tH094312@repo.freebsd.org> To: Mathieu Arnold X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 19:58:39 -0000 > On Aug 30, 2017, at 3:54 PM, Mathieu Arnold wrote: >=20 > Le 30/08/2017 =C3=A0 21:47, Emanuel Haupt a =C3=A9crit : >>=20 >>=20 >> On 30.08.17 21:32, Dan Langille wrote: >>> Author: dvl >>> Date: Wed Aug 30 19:32:00 2017 >>> New Revision: 448998 >>> URL: https://svnweb.freebsd.org/changeset/ports/448998 >>>=20 >>> Log: >>> Add base/port options for libpcap >>> PR: 221923 >>> Approved by: ehaupt (maintainer) >>>=20 >>> Modified: >>> head/net-mgmt/tcpreplay/Makefile >>>=20 >>> Modified: head/net-mgmt/tcpreplay/Makefile >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>=20 >>> --- head/net-mgmt/tcpreplay/Makefile Wed Aug 30 19:18:00 2017 =20= >>> (r448997) >>> +++ head/net-mgmt/tcpreplay/Makefile Wed Aug 30 19:32:00 2017 =20= >>> (r448998) >>> @@ -4,6 +4,7 @@ >>> PORTNAME=3D tcpreplay >>> PORTVERSION=3D 4.2.6 >>> DISTVERSIONPREFIX=3D v >>> +PORTREVISION=3D 1 >>> CATEGORIES=3D net-mgmt >>> MAINTAINER=3D ehaupt@FreeBSD.org >>> @@ -26,6 +27,18 @@ CONFIGURE_ARGS=3D =20 >>> --program-transform-name=3D's|.*\(tcp.*\ >>> # required when using autogen >>> CONFIGURE_ARGS+=3D --disable-local-libopts = --disable-libopts-install >>> + >>> +OPTIONS_DEFINE=3D LIBPCAP_BASE LIBPCAP_PORTS >>> +LIBPCAP_BASE=3D Build with libpcap from the base OS >>> +LIBPCAP_PORTS=3D Build with net/libpcap >>> + >>> +OPTIONS_SINGLE=3D SG1 >>> +OPTIONS_SINGLE=3D LIBPCAP_BASE LIBPCAP_PORTS >>> + >>> +OPTIONS_DEFAULT=3D LIBPCAP_BASE >>> + >>> +LIBPCAP_PORTS_BUILD_DEPENDS=3D = ${LOCALBASE}/lib/libpcap.a:net/libpcap >>> +LIBPCAP_PORTS_LIB_DEPENDS=3D libpcap.so:net/libpcap >>> post-patch: >>> @${REINPLACE_CMD} -e 's|-Wall -O3||' >>> ${WRKSRC}/${CONFIGURE_SCRIPT}.ac >>>=20 >>=20 >> Are you going to add a description for LIBPCAP_BASE and LIBPCAP_PORTS >> in ports/Mk/bsd.options.desc.mk? Right now the two options have no >> description. >=20 > I think it would be faster to add _DESC for the options descriptions = here. I see the descriptions in there, but they are not correctly set. I will = fix this now. --=20 Dan Langille - BSDCan / PGCon dan@langille.org