From owner-freebsd-bugs@FreeBSD.ORG Fri Nov 30 16:50:00 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC91A16A419 for ; Fri, 30 Nov 2007 16:50:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C552C13C45A for ; Fri, 30 Nov 2007 16:50:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lAUGo0R5061545 for ; Fri, 30 Nov 2007 16:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lAUGo03J061544; Fri, 30 Nov 2007 16:50:00 GMT (envelope-from gnats) Resent-Date: Fri, 30 Nov 2007 16:50:00 GMT Resent-Message-Id: <200711301650.lAUGo03J061544@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexander Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6112B16A420 for ; Fri, 30 Nov 2007 16:41:11 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 5462213C455 for ; Fri, 30 Nov 2007 16:41:11 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lAUGewY7039618 for ; Fri, 30 Nov 2007 16:40:58 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id lAUGew8D039617; Fri, 30 Nov 2007 16:40:58 GMT (envelope-from nobody) Message-Id: <200711301640.lAUGew8D039617@www.freebsd.org> Date: Fri, 30 Nov 2007 16:40:58 GMT From: Alexander To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/118355: pfctl help message options order false -t must before -T X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2007 16:50:01 -0000 >Number: 118355 >Category: misc >Synopsis: pfctl help message options order false -t must before -T >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Nov 30 16:50:00 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Alexander >Release: 5.5-STABLE >Organization: >Environment: FreeBSD gaspode.meersau.de 5.5-STABLE FreeBSD 5.5-STABLE #11: Sat Nov 24 14:09:04 CET 2007 root@gaspode.meersau.de:/usr/obj/usr/src/sys/GASPODE i386 >Description: If I try to add a entry in a pf table the option -T must follow -t so this command fails: % sudo pfctl -T add 86.51.7.205 -t badhosts No ALTQ support in kernel ALTQ related functions disabled usage: pfctl [-AdeghNnOqRrvz] [-a anchor[:ruleset]] [-D macro=value] [-F modifier] [-f file] [-i interface] [-k host] [-p device] [-s modifier] [-T command [address ...]] [-t table] [-x level] % The help message does display the -t option behind -T. I think it would be help to see the options in the right order. Also the order in the manpage is to be corrected, but I don't know the syntax. >How-To-Repeat: pfctl -T add 86.51.7.205 -t badhosts >Fix: --- pfctl.c Fri Nov 30 17:38:24 2007 +++ pfctl.c.orig Fri Nov 30 17:37:34 2007 @@ -202,8 +202,8 @@ fprintf(stderr, "[-F modifier] [-f file] [-i interface] "); fprintf(stderr, "[-k host] [-p device]\n"); fprintf(stderr, " "); - fprintf(stderr, "[-s modifier] [-t table] [-T command [address ...]] "); - fprintf(stderr, "[-x level]\n"); + fprintf(stderr, "[-s modifier] [-T command [address ...]] "); + fprintf(stderr, "[-t table] [-x level]\n"); exit(1); } >Release-Note: >Audit-Trail: >Unformatted: