From owner-svn-src-head@FreeBSD.ORG Sun Jun 13 16:37:11 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C2A0106564A; Sun, 13 Jun 2010 16:37:11 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by mx1.freebsd.org (Postfix) with ESMTP id 2E5258FC23; Sun, 13 Jun 2010 16:37:11 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.4/8.14.4) with ESMTP id o5DGbAAd062842; Sun, 13 Jun 2010 09:37:10 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.4/8.14.4/Submit) id o5DGbA5a062841; Sun, 13 Jun 2010 09:37:10 -0700 (PDT) (envelope-from sgk) Date: Sun, 13 Jun 2010 09:37:10 -0700 From: Steve Kargl To: Kai Wang Message-ID: <20100613163710.GA62804@troutmask.apl.washington.edu> References: <201006131058.o5DAwo4b004987@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201006131058.o5DAwo4b004987@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209122 - head/lib/libelf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jun 2010 16:37:11 -0000 On Sun, Jun 13, 2010 at 10:58:50AM +0000, Kai Wang wrote: > Author: kaiw > Date: Sun Jun 13 10:58:50 2010 > New Revision: 209122 > URL: http://svn.freebsd.org/changeset/base/209122 > > Log: > * Improve compatibility with existing application code by permitting the > use of `elf_getbase()` on non-archive members. This change is needed > for gcc LTO (-flto) to work properly. > * Style fix: paranthesize returned values. > * Document the current behaviour of `elf_getbase()`. > > Tested by: gerald, Steve Kargl (original patch) > Obtained from: elftoolchain > MFC after: 3 days > > Modified: > head/lib/libelf/elf_getbase.3 > head/lib/libelf/elf_getbase.c Thanks. Unfortunately without the patch to elf_update.c, gcc LTO will not work (ie., 'gcc -flto -o z a.o b.o' will segfault). Any chance that the elf_update.c patch will be committed; possibly as a conditional compilation. -- Steve