Date: Tue, 17 Sep 2019 11:27:27 -0700 From: Randall Stewart <rrs@netflix.com> To: vm finance <vm.finance2@gmail.com> Cc: Jamie Landeg-Jones <jamie@catflap.org>, Ryan Stone <rysto32@gmail.com>, freebsd-net <freebsd-net@freebsd.org> Subject: Re: BBR patches? Message-ID: <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> In-Reply-To: <CAKy-8=jSdSFPJWL=cLeea-KSc=9wxR6vQTODibw7-GUh0XpCfw@mail.gmail.com> References: <CAKy-8=jUu=dbp1s7nhYBwgeh%2BiO-XY-YEnh1MJ81aYJoopVonA@mail.gmail.com> <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <CAKy-8=gZ8E73PZdxb33aN=TmfigcNyTvZP4wP3M-mAy9no-v6w@mail.gmail.com> <CAFMmRNxbX5f3s0ZZk=Epr7Gu7%2Bsjat8F0TV0aX_RwoFgX0s%2ByA@mail.gmail.com> <CAKy-8=g=3LC8u_vc_3_Pfe6pgoUxpvx7N_j=xv7nRaM%2BD1Oz-A@mail.gmail.com> <D35AF884-C631-42CE-ABFD-F4AA76AA6693@netflix.com> <CAKy-8=jSdSFPJWL=cLeea-KSc=9wxR6vQTODibw7-GUh0XpCfw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Pacing is provided by tcp_hpts.c. The current linux patches do not have to have fq.. they built an alternate means of doing pacing into bbr. In either case our testing has shown that our pacing is more accurate = than either fq or the internal pacer :) R > On Sep 17, 2019, at 11:05 AM, vm finance <vm.finance2@gmail.com> = wrote: >=20 > Thanks Randall. > I was able to apply the patch - now rebuilding the kernel. Would = update on how it goes. >=20 > BTW, is there any description on how lack of tc_fq under FreeBSD is = compensated here? > The original BBR patches on Linux show that as a must-have? Is that = functionality implemented via tcp_ratelimit.[ch]? >=20 > Any pointers to existing presentations/discussions highly appreciated? >=20 > Thanks a lot. >=20 > On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart <rrs@netflix.com> = wrote: > You should be able to compile it against the current head. I re-doing = that now (had an > issue with my machine and had to roll it back to a backup). >=20 > When I put the patch up on Sept 10th it complied with and without BBR = on whatever > was that rev.. >=20 > Looking in the commit logs that would have been around 352191 >=20 > Hope that helps >=20 > R >=20 > > On Sep 17, 2019, at 3:32 AM, vm finance <vm.finance2@gmail.com> = wrote: > >=20 > > Hi Randall, > >=20 > > Thanks for releasing BBR patch: > > https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq=20 > >=20 > > Could you please let me know what SVN/GIT label tag this is based = on? I would like to patch and experiment with it. I couldn't find this = info in the released patch. > >=20 > > Thanks a lot!=20 > >=20 > > On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone <rysto32@gmail.com> = wrote: > > rrs@ has just posted the BBR patch to phabricator: > >=20 > > https://reviews.freebsd.org/D21582 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?27AD43DA-3237-490A-B3A6-C1792F9674E5>