From owner-freebsd-bugs  Mon Oct 21 15:50:06 1996
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id PAA19670
          for bugs-outgoing; Mon, 21 Oct 1996 15:50:06 -0700 (PDT)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id PAA19650;
          Mon, 21 Oct 1996 15:50:03 -0700 (PDT)
Resent-Date: Mon, 21 Oct 1996 15:50:03 -0700 (PDT)
Resent-Message-Id: <199610212250.PAA19650@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, skynyrd@opus.cts.cwu.edu
Received: from pahtoh.cwu.edu (root@pahtoh.cwu.edu [198.104.65.27])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id PAA19509
          for <FreeBSD-gnats-submit@freebsd.org>; Mon, 21 Oct 1996 15:48:18 -0700 (PDT)
Received: from opus.cts.cwu.edu (root@opus.cts.cwu.edu [198.104.65.210]) by pahtoh.cwu.edu (8.6.13/8.6.9) with ESMTP id PAA00860 for <FreeBSD-gnats-submit@freebsd.org>; Mon, 21 Oct 1996 15:48:15 -0700
Received: (from skynyrd@localhost) by opus.cts.cwu.edu (8.6.13/8.6.12) id PAA07724; Mon, 21 Oct 1996 15:48:15 -0700
Message-Id: <199610212248.PAA07724@opus.cts.cwu.edu>
Date: Mon, 21 Oct 1996 15:48:15 -0700
From: skynyrd@opus.cts.cwu.edu
Reply-To: skynyrd@opus.cts.cwu.edu
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: kern/1859: fddi_input() floods system msg buffer when dropping noproto frames
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         1859
>Category:       kern
>Synopsis:       fddi_input() floods system msg buffer when dropping noproto frames
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 21 15:50:01 PDT 1996
>Last-Modified:
>Originator:     Chris Timmons
>Organization:
Central Washington University
>Release:        FreeBSD 2.1.5-RELEASE; 2.2-CURRENT
>Environment:

	DEFPA-DA adapter connected to ring where all sorts of non-IP protocols
	are present.

	Source module src/sys/net/if_fddisubr.c

>Description:

	Unlike ether_input() which silently discards frames which it does not
	queue for higher-layer processing, fddi_input() writes an informational
	message, once per packet.  The messages wind up in the system message
	buffer as viewed by dmesg(8).  Other messages are ultimately obscured.
	(Try working on the console with the default syslog.conf in effect at this
	time, too :)

	I can't think of a reason (other than debugging) why we would want to leave
	these printf's in the default code.

>How-To-Repeat:


	ifconfig fpa0 n.n.n.n netmask m.m.m.m up
	dmesg
>Fix:

patch against -CURRENT $Id: if_fddisubr.c,v 1.9 1996/06/10 23:07:31 gpalmer Exp $

*** if_fddisubr.c.OLD   Mon Jun 10 16:07:31 1996
--- if_fddisubr.c       Mon Oct 21 15:15:07 1996
***************
*** 445,451 ****
                        break;
  #endif
                default:
-                       printf("fddi_input: unknown protocol 0x%x\n", fddi_type);
                        ifp->if_noproto++;
                        goto dropanyway;
                }
--- 445,450 ----
***************
*** 538,544 ****
  #endif /* LLC */
  
        default:
-               printf("fddi_input: unknown dsap 0x%x\n", l->llc_dsap);
                ifp->if_noproto++;
        dropanyway:
                m_freem(m);
--- 537,542 ----
	

>Audit-Trail:
>Unformatted: