Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 04 Nov 2013 08:26:13 -0600
From:      Mark Felder <feld@FreeBSD.org>
To:        Eitan Adler <eadler@freebsd.org>
Cc:        svn-ports-head@freebsd.org, Tijl Coosemans <tijl@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r332567 - head/graphics/apvlv
Message-ID:  <1383575173.23601.42712325.3D04E827@webmail.messagingengine.com>
In-Reply-To: <CAF6rxgmWq6KkR3b5S82Y%2B6vf7XPv8gnBbz3v%2BDzP7GZsj=-sPg@mail.gmail.com>
References:  <201311030036.rA30aXLv016213@svn.freebsd.org> <20131103201410.2f95dc09@kalimero.tijl.coosemans.org> <CAF6rxgn4Bj9J%2Bre5V9yZNNZFTyX5o8EWDG7%2BN4WpJEGbK24Egg@mail.gmail.com> <1383574552.17263.42707017.6BE762CA@webmail.messagingengine.com> <CAF6rxgmWq6KkR3b5S82Y%2B6vf7XPv8gnBbz3v%2BDzP7GZsj=-sPg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 4, 2013, at 8:20, Eitan Adler wrote:
> On Mon, Nov 4, 2013 at 9:15 AM, Mark Felder <feld@freebsd.org> wrote:
> >
> >
> > On Sun, Nov 3, 2013, at 13:38, Eitan Adler wrote:
> >> On Sun, Nov 3, 2013 at 2:14 PM, Tijl Coosemans <tijl@freebsd.org> wrote:
> >>
> >> > but now PTHREAD_CFLAGS is always empty
> >>
> >> Which is always a mistake.  PTHREAD_CFLAGS should be replaced with
> >> -pthread
> >>
> >>  so you can remove that line and PTHREAD_LIBS is always
> >> > -pthread.
> >>
> >> As should this.
> >>
> >
> > Thanks for the feedback guys. Perhaps we should put PTHREAD_CFLAGS and
> > PTHREAD_LIBS into portlint as well.
> >
> > I'm not 100% sure I understand the changes you're proposing -- I'm
> > getting caught up on the wording. Is this diff what you're suggesting?
> 
> Yes.
> 

Thank you. I will commit this change after doing a quick build test to
ensure nothing crazy happens.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1383575173.23601.42712325.3D04E827>