Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 Jul 2019 21:59:46 +0200 (CEST)
From:      Gerald Pfeifer <gerald@pfeifer.com>
To:        Greg Lewis <glewis@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r505640 - head/java/openjdk11
Message-ID:  <alpine.LSU.2.21.1907092158010.4639@anthias.pfeifer.com>
In-Reply-To: <201907012118.x61LIIQr011692@repo.freebsd.org>
References:  <201907012118.x61LIIQr011692@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 1 Jul 2019, Greg Lewis wrote:
> Author: glewis
> Date: Mon Jul  1 21:18:18 2019
> New Revision: 505640
> URL: https://svnweb.freebsd.org/changeset/ports/505640
> 
> Log:
>   Allow the JDK to be compiled with gcc.

Why the following?

> Modified: head/java/openjdk11/Makefile
> ==============================================================================
> --- head/java/openjdk11/Makefile	Mon Jul  1 21:09:07 2019	(r505639)
> +++ head/java/openjdk11/Makefile	Mon Jul  1 21:18:18 2019	(r505640)
> @@ -37,12 +37,12 @@ MAKE_ENV=	LANG="C" \
>  		CLASSPATH="" \
>  		JAVA_HOME="" \
>  		LD_LIBRARY_PATH="" \
> -		CC=/usr/bin/cc \
> -		CXX=/usr/bin/c++ \
> -		MAKEFLAGS="" \
> -		USE_CLANG=true
> +		CC=${CC} \
> +		CXX=${CXX} \
> +		CPP=${CPP} \

Mk/bsd.ports.mk already has

   MAKE_ENV+=           PREFIX=${PREFIX} \
                        LOCALBASE=${LOCALBASE} \
                        CC="${CC}" CFLAGS="${CFLAGS}" \
                        CPP="${CPP}" CPPFLAGS="${CPPFLAGS}" \
                        LDFLAGS="${LDFLAGS}" LIBS="${LIBS}" \
                        CXX="${CXX}" CXXFLAGS="${CXXFLAGS}" \
                        MANPREFIX="${MANPREFIX}"

so unless I am missing something (which is quite possible), the
settings for CC, CPP, and CXX should not be necessary, should they?

Gerald



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1907092158010.4639>