From owner-svn-ports-head@freebsd.org Tue Jul 9 19:59:56 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D774515E4814; Tue, 9 Jul 2019 19:59:56 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0D00383CF8; Tue, 9 Jul 2019 19:59:55 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 3AD0433E38; Tue, 9 Jul 2019 15:59:55 -0400 (EDT) Received: from anthias.microfocus.com (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id 8B48233E37; Tue, 9 Jul 2019 15:59:54 -0400 (EDT) Date: Tue, 9 Jul 2019 21:59:46 +0200 (CEST) From: Gerald Pfeifer To: Greg Lewis cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505640 - head/java/openjdk11 In-Reply-To: <201907012118.x61LIIQr011692@repo.freebsd.org> Message-ID: References: <201907012118.x61LIIQr011692@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 0D00383CF8 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-5.39 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+a:hamza.pair.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[pfeifer.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-2.10)[ip: (-7.79), ipnet: 209.68.0.0/18(-1.58), asn: 7859(-1.08), country: US(-0.06)]; MX_GOOD(-0.01)[cached: mailwash29.pair.com]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; RCVD_IN_DNSWL_NONE(0.00)[143.5.68.209.list.dnswl.org : 127.0.10.0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jul 2019 19:59:57 -0000 On Mon, 1 Jul 2019, Greg Lewis wrote: > Author: glewis > Date: Mon Jul 1 21:18:18 2019 > New Revision: 505640 > URL: https://svnweb.freebsd.org/changeset/ports/505640 > > Log: > Allow the JDK to be compiled with gcc. Why the following? > Modified: head/java/openjdk11/Makefile > ============================================================================== > --- head/java/openjdk11/Makefile Mon Jul 1 21:09:07 2019 (r505639) > +++ head/java/openjdk11/Makefile Mon Jul 1 21:18:18 2019 (r505640) > @@ -37,12 +37,12 @@ MAKE_ENV= LANG="C" \ > CLASSPATH="" \ > JAVA_HOME="" \ > LD_LIBRARY_PATH="" \ > - CC=/usr/bin/cc \ > - CXX=/usr/bin/c++ \ > - MAKEFLAGS="" \ > - USE_CLANG=true > + CC=${CC} \ > + CXX=${CXX} \ > + CPP=${CPP} \ Mk/bsd.ports.mk already has MAKE_ENV+= PREFIX=${PREFIX} \ LOCALBASE=${LOCALBASE} \ CC="${CC}" CFLAGS="${CFLAGS}" \ CPP="${CPP}" CPPFLAGS="${CPPFLAGS}" \ LDFLAGS="${LDFLAGS}" LIBS="${LIBS}" \ CXX="${CXX}" CXXFLAGS="${CXXFLAGS}" \ MANPREFIX="${MANPREFIX}" so unless I am missing something (which is quite possible), the settings for CC, CPP, and CXX should not be necessary, should they? Gerald