From owner-cvs-all  Thu Mar  7 12:26:51 2002
Delivered-To: cvs-all@freebsd.org
Received: from patrocles.silby.com (d133.as21.nwbl0.wi.voyager.net [169.207.139.199])
	by hub.freebsd.org (Postfix) with ESMTP
	id 332CD37B405; Thu,  7 Mar 2002 12:26:45 -0800 (PST)
Received: from patrocles.silby.com (localhost [127.0.0.1])
	by patrocles.silby.com (8.12.2/8.12.2) with ESMTP id g27EVGNu003626;
	Thu, 7 Mar 2002 14:31:16 GMT
	(envelope-from silby@silby.com)
Received: from localhost (silby@localhost)
	by patrocles.silby.com (8.12.2/8.12.2/Submit) with ESMTP id g27EUpTO003616;
	Thu, 7 Mar 2002 14:30:52 GMT
X-Authentication-Warning: patrocles.silby.com: silby owned process doing -bs
Date: Thu, 7 Mar 2002 14:30:50 +0000 (GMT)
From: Mike Silbersack <silby@silby.com>
To: "David O'Brien" <obrien@FreeBSD.ORG>
Cc: Mark Murray <mark@grondar.za>, <cvs-committers@FreeBSD.ORG>,
	<cvs-all@FreeBSD.ORG>
Subject: Re: cvs commit: src/usr.bin/rwall rwall.c
In-Reply-To: <20020307120711.A62212@dragon.nuxi.com>
Message-ID: <20020307142738.U3443-100000@patrocles.silby.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


On Thu, 7 Mar 2002, David O'Brien wrote:

> On Thu, Mar 07, 2002 at 01:28:24PM +0000, Mark Murray wrote:
> > > This is by *NO* means more readable than the old code!
> >
> > I guess this comes down to an opinion, right? :-)
>
> There seems to be more NO's than agreements with you in this case.  BUT
> that does not matter.  We've operated under the "don't change things w/o
> a good reason" to (1) settle cases of opinion like this.  And (2) because
> changing things too much throws away over a decade of tested proven code.
> This is something that should not be taken lightly.  We hold our age up
> all the time as one of our advantages over Linux.  However these
> WARNS/lint runs are making our code as volatile as the GNU stuff we snub.

I believe I've asked this before, but I haven't heard a good answer:

What benefit do the WARNS changes have?

I'd understand the need for "strcpy -> strlcpy changes" or "snprintf
changes", but I don't see what good the WARNS changes are having.  Is this
documented somewhere?

Mike "Silby" Silbersack


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message