From owner-freebsd-bugs@FreeBSD.ORG Thu Feb 21 06:20:03 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0032F16A401 for ; Thu, 21 Feb 2008 06:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E6F3F13C442 for ; Thu, 21 Feb 2008 06:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m1L6K2Qg010173 for ; Thu, 21 Feb 2008 06:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m1L6K2cj010171; Thu, 21 Feb 2008 06:20:02 GMT (envelope-from gnats) Date: Thu, 21 Feb 2008 06:20:02 GMT Message-Id: <200802210620.m1L6K2cj010171@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Yoshihiro Ota Cc: Subject: Re: bin/120784: [patch] mount(8): allow mount from fstab with 3rd party tools like ntfs-3g X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Yoshihiro Ota List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2008 06:20:03 -0000 The following reply was made to PR bin/120784; it has been noted by GNATS. From: Yoshihiro Ota To: bug-followup@FreeBSD.org Cc: kamikaze@bsdforen.de Subject: Re: bin/120784: [patch] mount(8): allow mount from fstab with 3rd party tools like ntfs-3g Date: Thu, 21 Feb 2008 01:17:06 -0500 This is a multi-part message in MIME format. --Multipart=_Thu__21_Feb_2008_01_17_06_-0500_zWgRYxXQvZ/tL5k/ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit This problem was mentioned last February and long standing bug, i.e. http://docs.freebsd.org/cgi/getmsg.cgi?fetch=282404+0+archive/2007/freebsd-current/20070204.freebsd-current In 7-release, mount program is modified to rely on nmount system call based on the source code change I read. The implementation to detect whether it is to call nmount or mount_XXX is determined by a list of KNOWN external mount programs. THAT is the problem as I mentioned one year ago. mount(3) is more tied to nmount(2) so that it is more reasonable and appropriate to list all nmount2) supported file systems like my patch. This is another alternative to this problem. --Multipart=_Thu__21_Feb_2008_01_17_06_-0500_zWgRYxXQvZ/tL5k/ Content-Type: text/x-diff; name="mount_xxx.diff" Content-Disposition: attachment; filename="mount_xxx.diff" Content-Transfer-Encoding: 7bit ? mount.diff Index: mount.c =================================================================== RCS file: /home/ncvs/src/sbin/mount/mount.c,v retrieving revision 1.96 diff -u -r1.96 mount.c --- mount.c 25 Jun 2007 05:06:54 -0000 1.96 +++ mount.c 21 Feb 2008 06:11:45 -0000 @@ -134,17 +134,20 @@ */ unsigned int i; const char *fs[] = { - "cd9660", "mfs", "msdosfs", "nfs", "nfs4", "ntfs", - "nwfs", "nullfs", "portalfs", "smbfs", "udf", "unionfs", + "ufs", + "tmpfs", + "ext2fs", + "devfs", "fdescfs", "procfs", "linprocfs", "linsysfs", + "std", NULL }; for (i = 0; fs[i] != NULL; ++i) { if (strcmp(vfstype, fs[i]) == 0) - return (1); + return (0); } - return (0); + return (1); } static int --Multipart=_Thu__21_Feb_2008_01_17_06_-0500_zWgRYxXQvZ/tL5k/--