From owner-svn-src-all@FreeBSD.ORG Fri Apr 24 05:27:06 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E8E185FC for ; Fri, 24 Apr 2015 05:27:05 +0000 (UTC) Received: from nm18-vm2.bullet.mail.gq1.yahoo.com (nm18-vm2.bullet.mail.gq1.yahoo.com [98.136.217.217]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B71971503 for ; Fri, 24 Apr 2015 05:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1429853218; bh=QxFoRR8yb6O49E8K5pMCQZQo3dm8gNnj/ahtKlaLysc=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject; b=Au4P903x4xhCnUnCwHDpX+z8Evj23FSLdLGyXSAusXimofuF9ryfVfg7Mm0OM4M34RYa/XKi10FUKCyQ51HAfl90pevhtYLRVzs7SLgf4Tc7gkWo3RAzsy3TN1booLrgk13wQ1ZOxHYVGssSDW+C9h454KI2SWzD1vrqGlJ7gQBePfD5L26WKhOWq+Hgz9zI1nqn0bXRzxWro1v8QrkGQcJh+XKnpM87pbbqkA38uzp6whu5eup6CXwNRbNmMPkdy6srahMYFia5N/duUA+hsM7bTDfFbGkqoCkw4L16s6RYSJnxq3j8RTFBYewnnUFvMr2JLXc5Gmo5mWUut24Amw== Received: from [98.137.12.189] by nm18.bullet.mail.gq1.yahoo.com with NNFMP; 24 Apr 2015 05:26:58 -0000 Received: from [208.71.42.200] by tm10.bullet.mail.gq1.yahoo.com with NNFMP; 24 Apr 2015 05:26:58 -0000 Received: from [127.0.0.1] by smtp211.mail.gq1.yahoo.com with NNFMP; 24 Apr 2015 05:26:58 -0000 X-Yahoo-Newman-Id: 473614.4371.bm@smtp211.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: e0FFuP8VM1kq1zSJx1m31DfNsFK5AAd7Zaa2gdeO6A.IWn3 KJNMgS9p5XzSLyqs2jPzkq2WUdxR0.tt5djquR0zErA3Evhnj8mnS8QV5c4i yY1oCYYO8cxNJ9oMvo8qxph28O.egTcDv18K1hEMZKfnzwTSl.lCDHZeyU6s yMrCVB8os.8v9.YK6FamobSjDg8fheNeCPRy9kCPz_zbyVOHHgeeqq4j1Qbr p5B8WgO87ZjIXr4dTuWGqnYI.nFAg3rvjWHmokIRkdZlS90cqldNJ2moAKXO oBX2SZul6N73CMx1JKjJ.I_DjPGH3_.gO_HyEScYasD0_CMNjIS223hEpIb2 DVZfYNpP_OjWWGYuY.5BARoJJI6QAMMUlQK_cRKGg2M4AJi39KGRw3W9vVxZ q1bno9je8t.yiaWCUGZE0lPkZdB_usuWdYshnroVGJYAvIMcJHf1rQ5xXXhL xl71dQMlTvUxGGbJAmF58xVxRIFdXE6VJpV7AUE3lUWavLDcDKgN.7wLkerN 4F8_J3FesHRo6t2wg.kAMnq5Hic5K3fxUFWgpsXC_ X-Yahoo-SMTP: clhABp.swBB7fs.LwIJpv3jkWgo2NU8- Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: svn commit: r281451 - head/sys/vm From: Scott Long In-Reply-To: <20150423192819.GA13122@dchagin.static.corbina.net> Date: Thu, 23 Apr 2015 23:26:55 -0600 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201504120621.t3C6LxAV095209@svn.freebsd.org> <5B48434B-EA97-45B3-BC4E-B039A868186B@yahoo.com> <4E109480-FD27-4C7F-8B5F-B1DB2232CD3D@yahoo.com> <20150423192819.GA13122@dchagin.static.corbina.net> To: Chagin Dmitry X-Mailer: Apple Mail (2.2070.6) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2015 05:27:06 -0000 > On Apr 23, 2015, at 1:28 PM, Chagin Dmitry = wrote: >=20 > On Thu, Apr 23, 2015 at 12:49:51PM -0600, Scott Long wrote: >>=20 >>> On Apr 23, 2015, at 6:19 AM, Scott Long = wrote: >>>=20 >>>>=20 >>>> On Apr 12, 2015, at 12:21 AM, Dmitry Chagin = wrote: >>>>=20 >>>> Author: dchagin >>>> Date: Sun Apr 12 06:21:58 2015 >>>> New Revision: 281451 >>>> URL: https://svnweb.freebsd.org/changeset/base/281451 >>>>=20 >>>> Log: >>>> Rework r281162. Indeed, the flexible array member is preferable = here. >>>>=20 >>>> Suggested by: Justin T. Gibbs >>>>=20 >>>> MFC after: 3 days >>>>=20 >>>> Modified: >>>> head/sys/vm/uma_core.c >>>> head/sys/vm/uma_int.h >>>=20 >>> There???s still something wrong with this. I have a machine with 28 = cores (56 with hyperthreading) and 256GB of RAM, and ever since you = committed r281162, it panics early in boot with a failed assertion. It = looks like the first few members of a uma_slab_t are getting overwritten = accidentally, and somehow the padding of the extra member in the = uma_zone_t was previously protecting it. I don???t know the exact cause = yet, but I must ask that you revert to r281161 in HEAD and stable/10 = until the problem is resolved. >>>=20 >>=20 >> I think the problem is that the masterzone_k and masterzone_z objects = that are statically allocated in uma_core.c no longer have space for the = uz_cpu field, but uma_zalloc_arg() always assumes that it???s there. = Early in boot when the ???kegs' and ???zones??? zones are being = initialized, there???s only 1 CPU so pre-allocating 1 uz_cpu element in = the uma_zone is enough. I can???t see any way around this without = significantly changing how uma_zalloc_arg() treats per-cpu caches. I = think it???s best to revert this change. >>=20 > Hi, > they initialized in uma_startup() and not used before. > I have a private converstion with a man which stable/10 hangs in = vm_mem_init().\ > with my commit. weird. >=20 > I do not object to revert, but give me a chance to figure out what's = going on. With INVARIANTS enabled, the system will panic. Without it, it will = spin in vm_mem_init(), as you noted. Even if it=E2=80=99s not happening = to everyone, it=E2=80=99s a serious problem for such a minor anticipated = benefit. I must insist that it be reverted. Scott