From owner-cvs-all@FreeBSD.ORG  Thu Jun 26 23:05:32 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0A3221065757;
	Thu, 26 Jun 2008 23:05:31 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id CF9EF8FC1D;
	Thu, 26 Jun 2008 23:05:31 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m5QN5VNb081650;
	Thu, 26 Jun 2008 23:05:31 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m5QN5VYF081649;
	Thu, 26 Jun 2008 23:05:31 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Message-Id: <200806262305.m5QN5VYF081649@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	rwatson@repoman.freebsd.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Date: Thu, 26 Jun 2008 23:05:28 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/net if.c if_var.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jun 2008 23:05:32 -0000

rwatson     2008-06-26 23:05:28 UTC

  FreeBSD src repository

  Modified files:
    sys/net              if.c if_var.h 
  Log:
  SVN rev 180042 on 2008-06-26 23:05:28Z by rwatson
  
  Introduce locking around use of ifindex_table, whose use was previously
  unsynchronized.  While races were extremely rare, we've now had a
  couple of reports of panics in environments involving large numbers of
  IPSEC tunnels being added very quickly on an active system.
  
  - Add accessor functions ifnet_byindex(), ifaddr_byindex(),
    ifdev_byindex() to replace existing accessor macros.  These functions
    now acquire the ifnet lock before derefencing the table.
  - Add IFNET_WLOCK_ASSERT().
  - Add static accessor functions ifnet_setbyindex(), ifdev_setbyindex(),
    which set values in the table either asserting of acquiring the ifnet
    lock.
  - Use accessor functions throughout if.c to modify and read
    ifindex_table.
  - Rework ifnet attach/detach to lock around ifindex_table modification.
  
  Note that these changes simply close races around use of ifindex_table,
  and make no attempt to solve the probem of disappearing ifnets.  Further
  refinement of this work, including with respect to ifindex_table
  resizing, is still required.
  
  In a future change, the ifnet lock should be converted from a mutex to an
  rwlock in order to reduce contention.
  
  Reviewed and tested by: brooks
  
  Revision  Changes    Path
  1.281     +69 -12    src/sys/net/if.c
  1.119     +4 -4      src/sys/net/if_var.h