Date: Tue, 27 Feb 2007 23:00:06 -0500 From: Tom Rhodes <trhodes@FreeBSD.org> To: Brooks Davis <brooks@FreeBSD.org> Cc: brooks@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org, des@des.no, mjacob@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/conf GENERIC src/sys/i386/conf GENERIC src/sys/ia64/conf GENERIC src/sys/pc98/conf GENERIC src/sys/powerpc/conf GENERIC src/sys/sparc64/conf GENERIC src/sys/sun4v/conf GENERIC Message-ID: <20070227230006.31cc8230.trhodes@FreeBSD.org> In-Reply-To: <20070227191721.GA40604@lor.one-eyed-alien.net> References: <200702091903.l19J3Ik5099479@repoman.freebsd.org> <86k5y6p9t2.fsf@dwp.des.no> <20070226172130.GB21095@lor.one-eyed-alien.net> <86vehohs7f.fsf@dwp.des.no> <20070227101456.H44348@ns1.feral.com> <20070227191721.GA40604@lor.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 27 Feb 2007 13:17:21 -0600 Brooks Davis <brooks@FreeBSD.org> wrote: > On Tue, Feb 27, 2007 at 10:16:16AM -0800, mjacob@freebsd.org wrote: > > > > I'm inclined to agree with Dag-Erling here. Originally I was > > pretty happy that this got turned on automatically, but on the whole I > > think the points made are good ones. > > I've reread Dag-Erling's post and I still don't agree that it should be > removed, but since this seems to be the consensus I'll wait few more > hours to see if that changes and then remove it until something is done > to prevent problems with duplicate labels. > > The basic reason I don't agree is that it requires effort to trip over > this bug. In no circumstance what to so ever will simply having this > option in your kernel cause any harm. Only if you add entries to your > fstab will problems occur. I don't see how not putting it in GENERIC > will fix this pilot error. Using labels in sysinstall is obviously > premature, but letting people use them a bit more seems like a very good > idea. :( I'm not using glabel(8), but perhaps a warning in GENERIC about the issue is worthy. Mainly because I agree that exposure is nice but users definitely deserve a warning. -- Tom Rhodes
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070227230006.31cc8230.trhodes>