From owner-svn-src-all@FreeBSD.ORG Sat Sep 11 13:36:32 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4268A106566C; Sat, 11 Sep 2010 13:36:32 +0000 (UTC) (envelope-from rpaulo@freebsd.org) Received: from karen.lavabit.com (karen.lavabit.com [72.249.41.33]) by mx1.freebsd.org (Postfix) with ESMTP id 196928FC1B; Sat, 11 Sep 2010 13:36:31 +0000 (UTC) Received: from d.earth.lavabit.com (d.earth.lavabit.com [192.168.111.13]) by karen.lavabit.com (Postfix) with ESMTP id 2109F24EDBA; Sat, 11 Sep 2010 08:36:31 -0500 (CDT) Received: from 10.0.10.3 (221.163.108.93.rev.vodafone.pt [93.108.163.221]) by lavabit.com with ESMTP id YB5A6H24LLZ1; Sat, 11 Sep 2010 08:36:31 -0500 Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: <20100911132314.GZ2465@deviant.kiev.zoral.com.ua> Date: Sat, 11 Sep 2010 14:36:26 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201009111258.o8BCwViM097096@svn.freebsd.org> <20100911132314.GZ2465@deviant.kiev.zoral.com.ua> To: Kostik Belousov X-Mailer: Apple Mail (2.1081) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212465 - head/sys/cddl/contrib/opensolaris/uts/common/dtrace X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Sep 2010 13:36:32 -0000 On 11 Sep 2010, at 14:23, Kostik Belousov wrote: > On Sat, Sep 11, 2010 at 12:58:31PM +0000, Rui Paulo wrote: >> Author: rpaulo >> Date: Sat Sep 11 12:58:31 2010 >> New Revision: 212465 >> URL: http://svn.freebsd.org/changeset/base/212465 >>=20 >> Log: >> Avoid a LOR (sleepable after non-sleepable) in >> fasttrap_tracepoint_enable(). >>=20 >> Sponsored by: The FreeBSD Foundation >>=20 >> Modified: >> head/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c >>=20 >> Modified: = head/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c = Sat Sep 11 12:51:01 2010 (r212464) >> +++ head/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c = Sat Sep 11 12:58:31 2010 (r212465) >> @@ -591,7 +591,9 @@ fasttrap_tracepoint_enable(proc_t *p, fa >> * Before we make any modifications, make sure we've imposed a = barrier >> * on the generation in which this probe was last modified. >> */ >> + PROC_UNLOCK(p); >> fasttrap_mod_barrier(probe->ftp_gen); >> + PROC_LOCK(p); >>=20 >> bucket =3D = &fasttrap_tpoints.fth_table[FASTTRAP_TPOINTS_INDEX(pid, pc)]; >>=20 > I suspect that you should hold the process around unlocked region. The unlocked region in the diff ? You're saying I shouldn't unlock/lock = here? > fasttrap_pid_enable() also does unlock, so it might be better to hold > the process immediately after pfind(). You mean use _PHOLD after pfind()? Regards, -- Rui Paulo