Date: Thu, 18 Dec 2008 23:00:28 +0100 From: Niclas Zeising <niclas.zeising@gmail.com> To: Alexander Motin <mav@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186296 - head/sys/dev/ata/chipsets Message-ID: <494AC7FC.8000805@gmail.com> In-Reply-To: <494AC77A.5010609@FreeBSD.org> References: <200812182113.mBILDkwt052441@svn.freebsd.org> <494AC475.20808@gmail.com> <494AC77A.5010609@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Motin wrote: > Niclas Zeising wrote: >> Alexander Motin wrote: >>> Author: mav >>> Date: Thu Dec 18 21:13:46 2008 >>> New Revision: 186296 >>> URL: http://svn.freebsd.org/changeset/base/186296 >>> >>> Log: >>> Before modularization commit, atapci driver was attaching only to >>> devices of >>> storage class. This check was lost. It is not important for the >>> most cases, >>> but as it was reported on current@, it does important for sis >>> driver and >>> surely inportant for AHCI driver. So restore it there. >>> Submitted by: Toshikazu ICHINOSEKI, Andrey V. Elsukov >>> Discussed on: current@ >>> >>> --- head/sys/dev/ata/chipsets/ata-sis.c Thu Dec 18 21:04:50 >>> 2008 (r186295) >>> +++ head/sys/dev/ata/chipsets/ata-sis.c Thu Dec 18 21:13:46 >>> 2008 (r186296) >>> @@ -105,6 +105,9 @@ ata_sis_probe(device_t dev) >>> char buffer[64]; >>> int found = 0; >>> >>> + if (pci_get_class(dev) != PCIC_STORAGE) >>> + return (ENXIO); >>> + >>> if (pci_get_vendor(dev) != ATA_SIS_ID) >>> return ENXIO; >> >> With this change, am I able to boot from a harddrive located on a >> SiS-controller again? Or is that more likely a different issue? >> I have't investigated my issue properly due to lack of time, so I >> don't know exactly what's wrong, only that it can't find the hard >> drive properly. > > I have no idea what your problem is, I am just a man. :) But if your > problem appeared on 8-CURRENT about two months ago, then it may be it > and so may be solved. > The dates seems approximately correct... I'm about to do a little magic (i.e. shuffeling harddrives around and whatnot) to compile a new kernel with the change, hopefully it works :) //Niclas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?494AC7FC.8000805>