From owner-svn-src-head@FreeBSD.ORG Sat Mar 28 14:27:07 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6A1F2F09; Sat, 28 Mar 2015 14:27:07 +0000 (UTC) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 196059B1; Sat, 28 Mar 2015 14:27:07 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id CEDC625D3A9B; Sat, 28 Mar 2015 14:27:03 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id C7C62C7707C; Sat, 28 Mar 2015 14:27:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id nE4RHmqVU5NL; Sat, 28 Mar 2015 14:27:01 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:b88f:8a06:70f:7ed3] (unknown [IPv6:fde9:577b:c1a9:4410:b88f:8a06:70f:7ed3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id B7079C7700C; Sat, 28 Mar 2015 14:27:00 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys From: "Bjoern A. Zeeb" In-Reply-To: <233AB248-B7A0-4A45-AB1B-6807D17C98B6@FreeBSD.org> Date: Sat, 28 Mar 2015 14:26:44 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <8CD30EE9-C338-40E9-ADB6-BE6AB5CE82F4@FreeBSD.org> References: <201503281250.t2SCoOkt020297@svn.freebsd.org> <233AB248-B7A0-4A45-AB1B-6807D17C98B6@FreeBSD.org> To: Randall Stewart X-Mailer: Apple Mail (2.2070.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2015 14:27:07 -0000 > On 28 Mar 2015, at 13:33 , Bjoern A. Zeeb wrote: >=20 >=20 >> On 28 Mar 2015, at 12:50 , Randall Stewart wrote: >>=20 >> Author: rrs >> Date: Sat Mar 28 12:50:24 2015 >> New Revision: 280785 >> URL: https://svnweb.freebsd.org/changeset/base/280785 >>=20 >> Log: >> Change the callout to supply -1 to indicate we are not changing >> CPU, also add protection against invalid CPU's as well as >> split c_flags and c_iflags so that if a user plays with the active >> flag (the one expected to be played with by callers in MPSAFE) = without >> a lock, it won't adversely affect the callout system by causing a = corrupt >> list. This also means that all callers need to use the macros and = *not* >> play with the falgs directly (like netgraph used to). >>=20 >> Differential Revision: htts://reviews.freebsd.org/D1894 >> Reviewed by: .. timed out but looked at by jhb, imp, adrian hselasky >> tested by hiren and netflix. >> Sponsored by: Netflix Inc. >>=20 >> Modified: >> head/sys/kern/kern_timeout.c >> head/sys/netgraph/atm/sscop/ng_sscop_cust.h >> head/sys/netgraph/atm/uni/ng_uni_cust.h >> head/sys/sys/_callout.h >> head/sys/sys/callout.h >=20 > I seem mips kernels starting to fail; might also be gcc kernels; = can=E2=80=99t say yet but you should fix this anyway please: >=20 > /scratch/tmp/bz/head.svn/sys/kern/kern_timeout.c: In function = 'callout_callwheel_init': > /scratch/tmp/bz/head.svn/sys/kern/kern_timeout.c:270: error: = convert_for_assignment: incompatible type for argument 1 of 'memset' > /scratch/tmp/bz/head.svn/sys/kern/kern_timeout.c: In function = 'callout_reset_sbt_on': > /scratch/tmp/bz/head.svn/sys/kern/kern_timeout.c:957: error: = subscripted value is neither array nor pointer Ah it=E2=80=99s !SMP it seems which is broken; oh well; looking. =E2=80=94=20 Bjoern A. Zeeb Charles Haddon Spurgeon: "Friendship is one of the sweetest joys of life. Many might have failed beneath the bitterness of their trial had they not found a friend."