Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Apr 2015 15:30:08 +0000 (UTC)
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r384056 - in head/java: openjdk7 openjdk8
Message-ID:  <201504151530.t3FFU8Rb030138@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bdrewery
Date: Wed Apr 15 15:30:07 2015
New Revision: 384056
URL: https://svnweb.freebsd.org/changeset/ports/384056

Log:
  Fix build with GCC with recent head kernel by disabling PCH for GCC.
  
  The case for this is a recent head kernel building an older branch that uses
  GCC in a jail.
  
  This is discussed at https://lists.freebsd.org/pipermail/svn-src-all/2015-March/101722.html
  
  It may be possible to fix GCC to do the right thing with mmap(2) but it would
  not be simple to make ports use a fixed GCC on older releases and without
  needlessly building a ports compiler when the system one would otherwise be
  fine without PCH.
  
  With hat:	portmgr

Modified:
  head/java/openjdk7/Makefile
  head/java/openjdk8/Makefile

Modified: head/java/openjdk7/Makefile
==============================================================================
--- head/java/openjdk7/Makefile	Wed Apr 15 15:16:02 2015	(r384055)
+++ head/java/openjdk7/Makefile	Wed Apr 15 15:30:07 2015	(r384056)
@@ -26,7 +26,7 @@ LICENSE=	GPLv2
 
 WRKSRC=		${WRKDIR}/${PORTNAME}
 
-USES=		dos2unix iconv gmake zip
+USES=		compiler dos2unix iconv gmake zip
 USE_XORG+=	x11 xext xi xrender xt xtst
 MAKE_ARGS=	CC=${CC:Q} CXX=${CXX:Q} HOST_CC=${CC:Q}
 
@@ -125,6 +125,11 @@ BUILD_DEPENDS+=		${BOOTSTRAPJDKDIR}/bin/
 
 .include <bsd.port.pre.mk>
 
+# GCC is broken with PCH: https://lists.freebsd.org/pipermail/svn-src-all/2015-March/101722.html
+.if ${COMPILER_TYPE} == gcc
+MAKE_ENV+=	USE_PRECOMPILED_HEADER=0
+.endif
+
 .if empty(ICONV_LIB)
 MAKE_ENV+=	EXTRA_CFLAGS=-DLIBICONV_PLUG
 .endif

Modified: head/java/openjdk8/Makefile
==============================================================================
--- head/java/openjdk8/Makefile	Wed Apr 15 15:16:02 2015	(r384055)
+++ head/java/openjdk8/Makefile	Wed Apr 15 15:30:07 2015	(r384056)
@@ -192,6 +192,11 @@ CONFIGURE_ENV=	LIBCXX="-lc++"
 .endif
 .endif
 
+# GCC is broken with PCH: https://lists.freebsd.org/pipermail/svn-src-all/2015-March/101722.html
+.if ${COMPILER_TYPE} == gcc
+MAKE_ARGS+=	USE_PRECOMPILED_HEADER=0
+.endif
+
 .if empty(ICONV_LIB)
 ICONV_CPPFLAGS=	-DLIBICONV_PLUG
 .else



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201504151530.t3FFU8Rb030138>