Date: Sun, 03 Feb 2008 11:31:37 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: kabaev@gmail.com Cc: gnome@freebsd.org Subject: Re: [PATCH] HAL is broken with real SCSI CD-ROM /CD-RW devices Message-ID: <1202056297.59813.10.camel@shumai.marcuscom.com> In-Reply-To: <20080203111558.21f8cc0f@kan.dnsalias.net> References: <20080203111558.21f8cc0f@kan.dnsalias.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-uwCaYZXu0yhcqbHMETOs Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, 2008-02-03 at 11:15 -0500, kabaev@gmail.com wrote: > Hi, >=20 > this a reserve copy in case one poseted to mainling lists gets lost > somehow. You seem to be the one doing majority of Gnome porting where > CAM is involved these days, so I thought direct message is warranted. >=20 > -- > Alexander Kabaev >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > Hi, >=20 > hal port as it exists on today's ports CVS works very badly with my > Plextor CD-RW, which hapens to be a generic SCSI-3/MMC2 device. Hal > hangs the drive firmware and sometimes oven freezes the whole SCSI bus > when probing for CDROM. It turns out that whoever did the initial hal > port did not know that CDB length parameter passed to CAM is > significant and just hardcoded it to 16. This causes 16 bytes of > command to be DMA's to the drive even for SCSI 6 and 10 byte commands > and that is not received warmly by at least some real SCSI targets. >=20 > Attached patch (also at > http://people.freebsd.org/~kan/hal-patch-scsi.diff) fixes this to > renaming unused timeout parameter in hfp_cdfrom_send_ccb function to be > ccb_len and passing proper command length where necessary. Thanks! I've committed this upstream (into hal git) which means it will make it into the upcoming GNOME 2.22 release. I'll also push this into our ports tree now. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-uwCaYZXu0yhcqbHMETOs Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEABECAAYFAkel7GcACgkQb2iPiv4Uz4ftnwCeOGUFTEMeuzhLsQQGeztAU8xl n6YAn2dDESGIsgSltj3RMYyz29SBIs/r =M5b0 -----END PGP SIGNATURE----- --=-uwCaYZXu0yhcqbHMETOs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1202056297.59813.10.camel>