Date: Fri, 09 Nov 2001 15:56:57 -0800 From: Peter Wemm <peter@wemm.org> To: Bruce Evans <bde@zeta.org.au> Cc: Poul-Henning Kamp <phk@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/libkern adddi3.c anddi3.c cmpdi2.c iordi3.c locc.c lshldi3.c muldi3.c negdi2.c notdi2.c subdi3.c xordi3.c Message-ID: <20011109235657.AD00E380A@overcee.netplex.com.au> In-Reply-To: <20011108203658.L1232-100000@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote:
> On Mon, 5 Nov 2001, Poul-Henning Kamp wrote:
>
> > phk 2001/11/05 13:10:10 PST
> >
> > Removed files:
> > sys/libkern adddi3.c anddi3.c cmpdi2.c iordi3.c
> > locc.c lshldi3.c muldi3.c negdi2.c
> > notdi2.c subdi3.c xordi3.c
> > Log:
> > Garbage call!
> >
> > These files have been obsoleted by compiler technology (such as it is
> > for gcc) for quite some time.
>
> Whether or not these files are used is machine-dependent. gcc emits
> calls to the functions in them as necessary. It just happens to be
> unnecessary for all currently supported machines. Similarly in libc,
> except optimizing out building of the unused routines is not very
> useful there and is only done for i386's.
>
> Please back this out.
Yes:
peter@daintree[3:48pm]~src/contrib/gcc-102> grep -r adddi3 . | wc -l
29
peter@daintree[3:49pm]~src/contrib/gcc-103> grep -r anddi3 . | wc -l
14
peter@daintree[3:49pm]~src/contrib/gcc-105> grep -r cmpdi2 . | wc -l
5
peter@daintree[3:49pm]~src/contrib/gcc-106> grep -r iordi3 . | wc -l
12
peter@daintree[3:50pm]~src/contrib/gcc-108> grep -r lshldi3 . | wc -l
0
peter@daintree[3:50pm]~src/contrib/gcc-109> grep -r muldi3 . | wc -l
16
peter@daintree[3:50pm]~src/contrib/gcc-110> grep -r negdi2 . | wc -l
17
peter@daintree[3:50pm]~src/contrib/gcc-111> grep -r notdi2 . | wc -l
0
peter@daintree[3:50pm]~src/contrib/gcc-112> grep -r subdi3 . | wc -l
15
peter@daintree[3:51pm]~src/contrib/gcc-113> grep -r xordi3 . | wc -l
18
notdi2 and lshldi3 probably should go. I'm not sure about locc.c, but
there are no apparent references to locc().
Sample references:
./config/alpha/alpha.md:(define_insn "xordi3"
./config/i386/i386.md:(define_insn "xordi3"
...
./config/alpha/alpha.c: seq = emit_insn (gen_subdi3 (stack_pointer_rtx, stack_pointer_rtx,
./config/alpha/alpha.md: emit_insn (gen_subdi3 (tmp, op1, op2));
./config/alpha/alpha.md: emit_insn (gen_subdi3 (gen_lowpart (DImode, operands[0]), op1, op2));
./config/alpha/alpha.md:(define_insn "subdi3"
./config/alpha/alpha.md: emit_insn (gen_subdi3 (want, stack_pointer_rtx,
./config/i386/i386.md:(define_insn "subdi3"
./config/sparc/sparc.md:(define_expand "subdi3"
...
./config/alpha/alpha.md:(define_insn "muldi3"
...
./config/alpha/alpha.md:(define_insn "iordi3"
./config/i386/i386.md:(define_insn "iordi3"
./config/sparc/sparc.md:(define_expand "iordi3"
...
etc. Therre are lots and lots of possible ways to generate references to
these on architectures that we do care about. We just dont have code in
the kernel that triggers calls to them at the moment.
Please do back this commit out. These are here so that people dont feel
the temptation to pull in GPL'ed code from libgcc.a.
Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011109235657.AD00E380A>