From owner-freebsd-bugs@FreeBSD.ORG Fri Feb 14 15:10:00 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9E797D7C for ; Fri, 14 Feb 2014 15:10:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 799F11234 for ; Fri, 14 Feb 2014 15:10:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s1EFA0lw035903 for ; Fri, 14 Feb 2014 15:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s1EFA0Yp035902; Fri, 14 Feb 2014 15:10:00 GMT (envelope-from gnats) Resent-Date: Fri, 14 Feb 2014 15:10:00 GMT Resent-Message-Id: <201402141510.s1EFA0Yp035902@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Takanori Sawada Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CA677C24 for ; Fri, 14 Feb 2014 15:06:45 +0000 (UTC) Received: from newred.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A6FB91212 for ; Fri, 14 Feb 2014 15:06:45 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by newred.freebsd.org (8.14.7/8.14.7) with ESMTP id s1EF6jVP029589 for ; Fri, 14 Feb 2014 15:06:45 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.7/8.14.7/Submit) id s1EF6jNc029575; Fri, 14 Feb 2014 15:06:45 GMT (envelope-from nobody) Message-Id: <201402141506.s1EF6jNc029575@cgiserv.freebsd.org> Date: Fri, 14 Feb 2014 15:06:45 GMT From: Takanori Sawada To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: bin/186766: [patch] sbin/pfctl fails to build X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Feb 2014 15:10:00 -0000 >Number: 186766 >Category: bin >Synopsis: [patch] sbin/pfctl fails to build >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Feb 14 15:10:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Takanori Sawada >Release: FreeBSD 10.0-RELEASE >Organization: >Environment: FreeBSD localhost.localdomain 10.0-RELEASE FreeBSD 10.0-RELEASE #12 r261181: Tue Feb 4 02:18:49 JST 2014 root@localhost.localdomain:/usr/obj/usr/src/sys/ProLiant_ML110_G7 amd64 >Description: FreeBSD Current Source sbin/pfctl fails to build. --- usr.sbin.all__D --- --- sdpd.8.gz --- gzip -cn /home/tak/share/github/freebsd/usr.sbin/bluetooth/sdpd/sdpd.8 > sdpd.8.gz --- sbin.all__D --- --- pfctl.o --- cc -O2 -fno-strict-aliasing -pipe -Wall -Wmissing-prototypes -Wno-uninitialized -Wstrict-prototypes -DENABLE_ALTQ -I/home/tak/share/github/freebsd/sbin/pfctl -DWITH_INET6 -DWITH_INET -std=gnu99 -Qunused-arguments -Wsystem-headers -Werr or -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-switch -Wno-switch-enu m -Wno-knr-promoted-parameter -c /home/tak/share/github/freebsd/sbin/pfctl/pfctl.c --- usr.sbin.all__D --- --- sdpd --- cc -O2 -fno-strict-aliasing -pipe -I/home/tak/share/github/freebsd/usr.sbin/bluetooth/sdpd -std=gnu99 -Qunused-arguments -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body -Wno-string-pl us-int -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -o sdpd bgd.o dun.o ftrn.o gn.o irmc.o irmc_command.o lan.o l og.o main.o nap.o opush.o panu.o profile.o provider.o sar.o scr.o sd.o server.o sp.o srr.o ssar.o ssr.o sur.o uuid.o ===> usr.sbin/bootparamd (all) --- all --- ===> usr.sbin/bootparamd/bootparamd (all) --- sbin.all__D --- /home/tak/share/github/freebsd/sbin/pfctl/pfctl.c:799:25: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] rule->bytes[1]), (uint64_t)rule->states_cur); ^~~~~~~~~~~~~~~~~~~~~~~~~~ /home/tak/share/github/freebsd/sbin/pfctl/pfctl.c:804:8: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] (uint64_t)rule->states_tot); ^~~~~~~~~~~~~~~~~~~~~~~~~~ --- usr.sbin.all__D --- --- bootparams.5.gz --- gzip -cn /home/tak/share/github/freebsd/usr.sbin/bootparamd/bootparamd/bootparams.5 > bootparams.5.gz --- bootparamd.8.gz --- gzip -cn /home/tak/share/github/freebsd/usr.sbin/bootparamd/bootparamd/bootparamd.8 > bootparamd.8.gz --- rescue.all__D --- --- printpool_live.o --- cc -O2 -fno-strict-aliasing -pipe -I. -DIPFILTER_BPF -DHAS_SYS_MD5_H -I/home/tak/share/github/freebsd/sbin/ipf/ipf/../../../contrib/ipfilter -I/home/tak/share/github/freebsd/sbin/ipf/ipf/../../../contrib/ipfilter/tools -I/home/tak/share /github/freebsd/sbin/ipf/ipf/../../../sys -I/home/tak/share/github/freebsd/sbin/ipf/ipf/../../../sys/contrib/ipfilter -DSTATETOP -D__UIO_EXPOSE -DRESCUE -std=gnu99 -Qunused-arguments -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-un initialized -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -W no-array-bounds -Wno-format -c /home/tak/share/github/freebsd/sbin/ipf/ipf/../../../contrib/ipfilter/lib/printpool_live.c --- sbin.all__D --- 2 errors generated. *** [pfctl.o] Error code 1 make[4]: stopped in /home/tak/share/github/freebsd/sbin/pfctl 1 error http://svnweb.freebsd.org/base/head/sbin/pfctl/pfctl.c?revision=261882&view=markup#l792 >How-To-Repeat: >Fix: Patch attached. Patch attached with submission follows: --- pfctl.c.orig 2014-02-14 23:32:07.000000000 +0900 +++ pfctl.c 2014-02-14 23:42:52.000000000 +0900 @@ -50,8 +50,10 @@ #include #include #include +#include #include #include +#include #include #include #include @@ -791,7 +793,7 @@ } if (opts & PF_OPT_VERBOSE) { printf(" [ Evaluations: %-8llu Packets: %-8llu " - "Bytes: %-10llu States: %-6lu]\n", + "Bytes: %-10llu States: %-6"PRIu64"]\n", (unsigned long long)rule->evaluations, (unsigned long long)(rule->packets[0] + rule->packets[1]), @@ -799,7 +801,7 @@ rule->bytes[1]), (uint64_t)rule->states_cur); if (!(opts & PF_OPT_DEBUG)) printf(" [ Inserted: uid %u pid %u " - "State Creations: %-6lu]\n", + "State Creations: %-6"PRIu64"]\n", (unsigned)rule->cuid, (unsigned)rule->cpid, (uint64_t)rule->states_tot); } >Release-Note: >Audit-Trail: >Unformatted: