From owner-freebsd-current Sat Dec 14 16: 9: 1 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C5A437B401; Sat, 14 Dec 2002 16:09:00 -0800 (PST) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9CD843EC2; Sat, 14 Dec 2002 16:08:59 -0800 (PST) (envelope-from sam@errno.com) Received: from melange (melange.errno.com [66.127.85.82]) (authenticated bits=0) by ebb.errno.com (8.12.5/8.12.1) with ESMTP id gBF08w9i067440 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sat, 14 Dec 2002 16:08:58 -0800 (PST)?g (envelope-from sam@errno.com)œ X-Authentication-Warning: ebb.errno.com: Host melange.errno.com [66.127.85.82] claimed to be melange Message-ID: <23f401c2a3ce$2a6e7e30$52557f42@errno.com> From: "Sam Leffler" To: "Matthew Dillon" , "Maxime Henrion" Cc: "David O'Brien" , References: <200212142025.aa99706@salmon.maths.tcd.ie> <200212142038.gBEKcDVv029924@apollo.backplane.com> <20021214204426.GA62058@dragon.nuxi.com> <200212142209.gBEM9D8p002479@apollo.backplane.com> <20021214221252.GF27086@elvis.mu.org> <200212142222.gBEMMqcn002571@apollo.backplane.com> <20021214224524.GG27086@elvis.mu.org> <200212142351.gBENpBVH002931@apollo.backplane.com> Subject: Re: ipfw userland breaks again. Date: Sat, 14 Dec 2002 16:08:58 -0800 Organization: Errno Consulting MIME-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4807.1700 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > :Now I would really dislike seeing your patch in the tree, since I > :consider it's a rather crude hack to circumvent the ABI problems of > :ipfw. As I've already said to luigi in private e-mail (I would be > :surprised if this hasn't been already discussed in the lists as well), > :the proper way to fix this problem is to separate the kernel and > :userland structures of ipfw, and add versioning to the struct. > : > :This can be done without even breaking the ABI again, since several > :pointers in the kernel structures are useless to userland (like the next > :field) and can be reused to implement structure versioning. > : > :Cheers, > :Maxime > > If/when Luigi fixes the ABI problems with IPFW, we can remove > this 'hack'. Until then, I do not consider the hackiness nature > of the patch sufficient reason to not put it in. I've been bitten > by this problem dozens of times, and wasted many hours simply because > I couldn't get the damn network working, and so have others. I disagree with committing this hack; keep it as a local mod if you must. As to the problem; don't wait for Luigi to "fix the ABI problems", do it yourself. Good things happen when folks are PO'd and won't settle for the status quo. Sam To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message