Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Apr 2011 10:49:54 +0300
From:      Jaakko Heinonen <jh@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Cc:        jamie@FreeBSD.org
Subject:   Re: svn commit: r220937 - head/sys/kern
Message-ID:  <20110422074953.GA53521@a91-153-123-205.elisa-laajakaista.fi>
In-Reply-To: <201104220726.p3M7Q9pZ031647@svn.freebsd.org>
References:  <201104220726.p3M7Q9pZ031647@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

(jamie@ Cc'd because kern_jail.c also uses the vfsopt framework.)

On 2011-04-22, Jaakko Heinonen wrote:
> + * XXX: This function will keep a "nofoo" option in the new
> + * options.  E.g, if the option's canonical name is "foo",
> + * "nofoo" ends up in the mount point's active options.

I have a follow-up patch which adds a flags field to the vfsopt struct
and changes vfs_filteropt() to mark options which should not become
active but only cancel other options with a flag. This allows
vfs_mergeopts() to know which options should be made active.

With these changes we can remove the "foo" -> "nonofoo" conversions from
vfs_donmount() for options whose canonical name starts with "no".

The patch:

	http://people.freebsd.org/~jh/patches/nmount-VFSOPT_CANCELONLY.diff

-- 
Jaakko



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110422074953.GA53521>