From owner-freebsd-stable Thu Apr 10 03:19:51 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id DAA27252 for stable-outgoing; Thu, 10 Apr 1997 03:19:51 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id DAA27247 for ; Thu, 10 Apr 1997 03:19:46 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id UAA30408; Thu, 10 Apr 1997 20:03:11 +1000 Date: Thu, 10 Apr 1997 20:03:11 +1000 From: Bruce Evans Message-Id: <199704101003.UAA30408@godzilla.zeta.org.au> To: davidn@unique.usn.blaze.net.au, jdp@polstra.com Subject: Re: games hierarchy breaks 2.2.1 build Cc: mdavis@io.cts.com, stable@FreeBSD.ORG Sender: owner-stable@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> > Although /usr/src/games did not exist, it was the none-too-obvious >> > /usr/obj/usr/src/games that did which caused the problem. >> >> Really?! That seems like completely bogus behavior on the part of "make". >> Could you please use "send-pr" to file a bug report? > >Bogus or not, it makes sense in terms of how make handles >the object directory and is consitent with how it behaves >with all files relative to the "current" directory. Yes, make always cd's to the obj directory if there is one, so that the current directory is always the object directory. >.if exists(games) && !defined(NOGAMES) >SUBDIR+= games >.endif > >This test (and others of a similar type) should be changed to: > >.if exists(${.CURDIR}/games) && !defined(NOGAMES) >SUBDIR+= games >.endif The test used to work when there was no obj directory in /usr/src, so make didn't cd to it, but now that the object tree exists independently of symlinks to it, there is no way to avoid having a (virtual) obj directory in /usr/src. Bruce