From owner-freebsd-ports-bugs@FreeBSD.ORG Mon May 8 23:30:23 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2483216A400 for ; Mon, 8 May 2006 23:30:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D4BCD43D46 for ; Mon, 8 May 2006 23:30:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k48NUMfA058543 for ; Mon, 8 May 2006 23:30:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k48NUMH2058541; Mon, 8 May 2006 23:30:22 GMT (envelope-from gnats) Date: Mon, 8 May 2006 23:30:22 GMT Message-Id: <200605082330.k48NUMH2058541@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Brad Huntting Cc: Subject: Re: ports/96918: sysutils/fcron: fcrondyn completely broken X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Brad Huntting List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 May 2006 23:30:23 -0000 The following reply was made to PR ports/96918; it has been noted by GNATS. From: Brad Huntting To: Edwin Groothuis Cc: huntting@glarp.com Subject: Re: ports/96918: sysutils/fcron: fcrondyn completely broken Date: Mon, 08 May 2006 09:34:51 -0600 Please let me know how the attached patch works. cd /tmp; cp -r /usr/ports/sysutils/fcron . patch ++#endif ++ + char rcs_info[] = "$Id: fcrondyn.c,v 1.14 2006/01/11 00:48:33 thib Exp thib $"; + + void info(void); +@@ -399,17 +403,21 @@ + int fd = -1; + struct sockaddr_un addr; + int len = 0; ++ int sa_len; + + if ( (fd = socket(PF_UNIX, SOCK_STREAM, 0)) == -1 ) + die_e("could not create socket"); + + addr.sun_family = AF_UNIX; +- if ( (len = strlen(fifofile)) > sizeof(addr.sun_path) ) +- die("Error : fifo file path too long (max is %d)", sizeof(addr.sun_path)); +- strncpy(addr.sun_path, fifofile, sizeof(addr.sun_path) - 1); +- addr.sun_path[sizeof(addr.sun_path)-1] = '\0'; ++ if ( (len = strlen(fifofile)) > sizeof(addr.sun_path) - 1 ) ++ die("Error : fifo file path too long (max is %d)", sizeof(addr.sun_path) - 1); ++ strncpy(addr.sun_path, fifofile, sizeof(addr.sun_path)); ++ sa_len = (addr.sun_path - (char *)&addr) + len; ++#if (defined(BSD) && (BSD >= 199103)) /* 4.3BSD Net2 */ ++ addr.sun_len = sa_len; ++#endif + +- if ( connect(fd, (struct sockaddr *) &addr, sizeof(addr.sun_family) + len) < 0 ) ++ if ( connect(fd, (struct sockaddr *) &addr, sa_len) < 0 ) + die_e("Cannot connect() to fcron (check if fcron is running)"); + + if ( authenticate_user(fd) == ERR ) { diff -Nru /usr/ports/sysutils/fcron/files/pkg-message.in fcron/files/pkg-message.in --- /usr/ports/sysutils/fcron/files/pkg-message.in Fri Feb 10 02:51:04 2006 +++ fcron/files/pkg-message.in Mon May 8 09:24:35 2006 @@ -5,12 +5,6 @@ fcron_enable="YES" cron_enable="NO" -install the pam config files - - mkdir -p %%PREFIX%%/etc/pam.d - cp %%EXAMPLESDIR%%/fcron.pam %%PREFIX%%/etc/pam.d/fcron - cp %%EXAMPLESDIR%%/fcrontab.pam %%PREFIX%%/etc/pam.d/fcrontab - and move any jobs in /etc/crontab to the root fcrontab(5) file. See: %%EXAMPLESDIR%% diff -Nru /usr/ports/sysutils/fcron/pkg-plist fcron/pkg-plist --- /usr/ports/sysutils/fcron/pkg-plist Fri Feb 10 02:51:04 2006 +++ fcron/pkg-plist Sun May 7 11:04:50 2006 @@ -5,8 +5,8 @@ etc/fcron.conf.dist etc/fcron.deny.dist sbin/fcron -%%EXAMPLESDIR%%/fcron.pam +%%PAMDIR%%/fcron +%%PAMDIR%%/fcrontab %%EXAMPLESDIR%%/fcrontab-operator %%EXAMPLESDIR%%/fcrontab-root -%%EXAMPLESDIR%%/fcrontab.pam @dirrm %%EXAMPLESDIR%%