Date: Wed, 19 Mar 2014 09:00:32 +0400 From: Andrew Rybchenko <Andrew.Rybchenko@oktetlabs.ru> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: net@FreeBSD.org Subject: Re: [PATCH 1/6] sfxge: fix mbuf leak if it does not fit in software queue Message-ID: <53292470.801@oktetlabs.ru> In-Reply-To: <20140318124624.GD1499@FreeBSD.org> References: <53280DB3.4080900@oktetlabs.ru> <20140318124624.GD1499@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gleb, On 03/18/2014 04:46 PM, Gleb Smirnoff wrote: > Andrew, > > On Tue, Mar 18, 2014 at 01:11:15PM +0400, Andrew Rybchenko wrote: > A> > A> sfxge: fix mbuf leak if it does not fit in software queue > A> > A> mbuf should be owned by if_transmit function in any case. > A> > A> Submitted-by: Andrew Rybchenko <Andrew.Rybchenko@oktetlabs.ru> > A> Sponsored by: Solarflare Communications, Inc. > > Can we simplify the function while here? One of the next patches (4/6) moves link down check to the function and uses "fail" label to increment early drops statistics and free mbuf. IMHO, it is really nice to have single place to do it. Thanks, Andrew. -- Andrew Rybchenko OKTET Labs, St.-Petersburg, Russia Web: www.oktetlabs.ru Office: +7 812 7832191 Fax: +7 812 7846591 Mobile: +7 921 7479683
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53292470.801>