Date: Thu, 29 Apr 2010 11:12:39 GMT From: Frank Wall <fw@moov.de> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/146147: [patch] mail/roundcube: add installer and scripts Message-ID: <201004291112.o3TBCdUp063701@www.freebsd.org> Resent-Message-ID: <201004291120.o3TBK1JI076046@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 146147
>Category: ports
>Synopsis: [patch] mail/roundcube: add installer and scripts
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Apr 29 11:20:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Frank Wall
>Release: 7.1-RELEASE-p4
>Organization:
>Environment:
FreeBSD 7.1-RELEASE-p4 FreeBSD 7.1-RELEASE-p4 #0: Sun Mar 22 09:43:46 UTC 2009 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
The port mail/roundcube does not include the roundcube installer. Besides it removes the shell scripts from the "bin" subfolder. Both is part of the roundcube distribution and should be included with this port.
In fact the installer and the shell scripts are useful for setup/upgrading roundcube.
The patch is just a proposal, I'm open for ideas and suggestions.
>How-To-Repeat:
1. install mail/roundcube
2. the subfolder "installer" is missing
3. the .sh scripts in "bin" are missing
>Fix:
This patch introduces LITE as a new OPTION and enables it by default (think of it as a "lite" distribution of roundcube). This is to preserve the old bevahiour.
If someone wants the installer the option LITE should be disabled.
Patch attached with submission follows:
Index: mail/roundcube/Makefile
===================================================================
--- mail/roundcube/Makefile (revision 843)
+++ mail/roundcube/Makefile (working copy)
@@ -47,10 +47,15 @@
LDAP "Enable LDAP support (address book)" off \
PSPELL "Enable PSpell support (internal spellcheck)" off \
NSC "Install network spellchecker" off \
- AUTOCOMP "Enable autocomplete in login form" off
+ AUTOCOMP "Enable autocomplete in login form" off \
+ LITE "Remove installer and shell scripts" on
.include <bsd.port.pre.mk>
+.if !defined(WITH_LITE) || defined(WITHOUT_LITE)
+RCUBECOMP+= installer
+.endif
+
.if defined(WITHOUT_MYSQL) && !defined(WITH_PGSQL) && !defined(WITH_SQLITE)
IGNORE= needs a database backend
.endif
@@ -93,7 +98,9 @@
.endif
post-patch:
+.if !defined(WITH_LITE) || defined(WITHOUT_LITE)
@${RM} ${WRKSRC}/bin/*.sh
+.endif
@${FIND} ${WRKSRC} -name \*.orig -type f -delete
.if defined(WITH_AUTOCOMP)
@${REINPLACE_CMD} "s/ autocomplete=\"off\"//g" \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201004291112.o3TBCdUp063701>