Date: Fri, 5 Feb 2016 13:53:42 +0800 From: Sepherosa Ziehau <sephe@freebsd.org> To: Andriy Voskoboinyk <avos@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r295302 - head/sys/dev/hyperv/netvsc Message-ID: <CAMOc5cywvory9JNi6LbWrGKDoD9W4gQq2T5tHTG1%2BVToUW--Bg@mail.gmail.com> In-Reply-To: <op.ycchq3jv4dikkl@localhost> References: <201602050525.u155PBCX071820@repo.freebsd.org> <op.ycchq3jv4dikkl@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
Oh, thanks, will fix it :)
On Fri, Feb 5, 2016 at 1:34 PM, Andriy Voskoboinyk <avos@freebsd.org> wrote=
:
> Fri, 05 Feb 2016 07:25:11 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0=
=BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Sepherosa Ziehau
> <sephe@freebsd.org>:
>
>> Modified: head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> ...
>> @@ -744,31 +745,235 @@ netvsc_channel_rollup(struct hv_device *
>> }
>> /*
>> - * Start a transmit of one or more packets
>> + * NOTE:
>> + * This this function fails, then both txd and m_head0 will be freed
>
>
> Probably "If this function fails.." ?
>
>
>> */
>> static int
>> -hn_start_locked(struct ifnet *ifp, int len)
>> +hn_encap(struct hn_softc *sc, struct hn_txdesc *txd, struct mbuf
>> **m_head0)
>> {
--=20
Tomorrow Will Never Die
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMOc5cywvory9JNi6LbWrGKDoD9W4gQq2T5tHTG1%2BVToUW--Bg>