From owner-freebsd-net@FreeBSD.ORG Mon Oct 6 17:56:59 2014 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A4A162FD for ; Mon, 6 Oct 2014 17:56:59 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7389AFBA for ; Mon, 6 Oct 2014 17:56:59 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s96Hux9O076640 for ; Mon, 6 Oct 2014 17:56:59 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 193053] ixgbe(4) IXGBE_LEGACY_TX + ALTQ path broken Date: Mon, 06 Oct 2014 17:56:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 9.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ncrogers@gmail.com X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Oct 2014 17:56:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193053 --- Comment #15 from ncrogers@gmail.com --- (In reply to Dan from comment #14) > I think a patch like the following would make using legacy mode easier. > This one is for IGB, but a similar one would work for IXGBE: I think thats a good idea and something that I've requested in the past. I am not sure if there is an existing PR for it or not. Can you please start a new PR/bug in regards to making IGB/IXGBE LEGACY a kernel option? I would like to keep this bug focussed on fixing the IXGBE_LEGACY_TX path which currently doesn't even compile. Thanks. > > Index: sys/conf/options > =================================================================== > --- sys/conf/options (revision 272659) > +++ sys/conf/options (working copy) > @@ -405,6 +405,7 @@ > ETHER_8023 opt_ef.h > ETHER_II opt_ef.h > ETHER_SNAP opt_ef.h > +IGB_LEGACY_TX opt_igb.h > INET opt_inet.h > INET6 opt_inet6.h > IPDIVERT > Index: sys/dev/e1000/if_igb.c > =================================================================== > --- sys/dev/e1000/if_igb.c (revision 272659) > +++ sys/dev/e1000/if_igb.c (working copy) > @@ -33,6 +33,8 @@ > /*$FreeBSD$*/ > > > +#include "opt_igb.h" > + > #include "opt_inet.h" > #include "opt_inet6.h" > > Index: sys/dev/e1000/if_igb.h > =================================================================== > --- sys/dev/e1000/if_igb.h (revision 272659) > +++ sys/dev/e1000/if_igb.h (working copy) > @@ -35,6 +35,8 @@ > #ifndef _IGB_H_DEFINED_ > #define _IGB_H_DEFINED_ > > +#include "opt_igb.h" > + > /* Tunables */ > > /* -- You are receiving this mail because: You are the assignee for the bug.