From owner-freebsd-current@FreeBSD.ORG Fri Aug 20 21:21:14 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 721421065694 for ; Fri, 20 Aug 2010 21:21:14 +0000 (UTC) (envelope-from rpaulo@freebsd.org) Received: from karen.lavabit.com (karen.lavabit.com [72.249.41.33]) by mx1.freebsd.org (Postfix) with ESMTP id 4B1568FC1C for ; Fri, 20 Aug 2010 21:21:14 +0000 (UTC) Received: from d.earth.lavabit.com (d.earth.lavabit.com [192.168.111.13]) by karen.lavabit.com (Postfix) with ESMTP id 5BCE111B966; Fri, 20 Aug 2010 16:21:13 -0500 (CDT) Received: from 10.0.10.3 (54.81.54.77.rev.vodafone.pt [77.54.81.54]) by lavabit.com with ESMTP id VPI314LVFWM4; Fri, 20 Aug 2010 16:21:13 -0500 Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: <9674C06D-DC2D-40C3-B523-E397C9ADC37B@christianserving.org> Date: Fri, 20 Aug 2010 22:21:10 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <641B7F47-CD12-415D-A808-861F4E85F60C@FreeBSD.org> References: <9674C06D-DC2D-40C3-B523-E397C9ADC37B@christianserving.org> To: Jim Riggs X-Mailer: Apple Mail (2.1081) Cc: freebsd-current@freebsd.org Subject: Re: CD/DVD ejecting after sysinstall X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2010 21:21:14 -0000 On 20 Aug 2010, at 20:46, Jim Riggs wrote: > References: >=20 > http://www.mail-archive.com/svn-src-all@freebsd.org/msg24380.html > http://forums.freebsd.org/showthread.php?t=3D17126 >=20 >=20 > This commit automatically ejects the CD when sysinstall exits which = almost had dire consequences for me this week. As described in the = forum post, I keep a LiveFS CD in all of my servers so that I can = remotely diagnose and fix issues. I have done this for several years = now, and it has saved my tail many times. >=20 > However, I got a surprise when I tried it today with the new 8.1 = LiveFS CDs I had just burned. After attempting to fix a problem from = the LiveFS and rebooting back to the HD, the problem still existed. No = problem. I just tried to boot back to the CD only to find that it was = gone. Luckily, this was on a box in-house, so I was quickly able to see = what was wrong. >=20 > Now that I have the commit, I can roll my own patched sysinstall and = CDs, but the question is: Should we be ejecting the media without any = prompt? Obviously, for my use case, I liked the old behavior of just = reminding the user to eject the media when rebooting. I understand that = may not be optimal for some users. Can we present a dialog asking the = user if they want the media to be ejected? That still leaves me at risk = of selecting the wrong answer, I suppose. I would rather not have to = roll my own LiveFS CDs every time, though. >=20 > Thoughts from anyone else? (Please copy me on responses.) You are correct. We should not be ejecting the CD without a prompt. If = the commit is reverted, it should be explicitly noted in the code so = that we don't do this mistake again. Regards, -- Rui Paulo