Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 May 2008 14:44:30 +0200 (CEST)
From:      Ed Schouten <ed@80386.nl>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/123591: [Patch] sysutils/screen: don't make it use /dev/ptmx
Message-ID:  <20080511124430.807F71CDC2@palm.hoeg.nl>
Resent-Message-ID: <200805111250.m4BCo5OC012961@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         123591
>Category:       ports
>Synopsis:       [Patch] sysutils/screen: don't make it use /dev/ptmx
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 11 12:50:05 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Ed Schouten
>Release:        FreeBSD 6.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD palm.hoeg.nl 6.3-STABLE FreeBSD 6.3-STABLE #0: Sun Apr 20 17:23:31 CEST 2008 ed@palm.hoeg.nl:/usr/obj/usr/src/sys/PALM i386
>Description:
The new TTY layer I'm developing supports the /dev/ptmx device to remain
compatible with Linux and FreeBSD binaries.

I notice that screen's configure tries to detect /dev/ptmx. If it is
present, it prefers /dev/ptmx over the openpty() routine that's
currently being used.

We shouldn't use it, because screen fails to use the allocated PTY
afterwards.
>How-To-Repeat:
>Fix:
The following patch makes the configure script check for /nonexistent
instead of /dev/ptmx, which doesn't exist. This effectively disables the
/dev/ptmx code in screen.

--- sysutils/screen/Makefile
+++ sysutils/screen/Makefile
@@ -64,6 +64,7 @@
 
 post-patch:
 	@${RM} ${WRKSRC}/doc/screen.info*
+	@${REINPLACE_CMD} -e 's|/dev/ptmx|/nonexistent|' ${WRKSRC}/configure
 
 post-install:
 	@${MKDIR} ${EXAMPLESDIR}
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080511124430.807F71CDC2>