Date: Tue, 11 Jun 2013 18:40:37 +0200 From: Baptiste Daroussin <bapt@freebsd.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r320546 - in head/devel: . tradcpp tradcpp/files Message-ID: <20130611164037.GD35160@ithaqua.etoilebsd.net> In-Reply-To: <CAF6rxg=iqSGrFK3Ug0Hzh6nRGnzUA5-Ug_aXrGs4xybBPAty3A@mail.gmail.com> References: <201306111055.r5BAtHmb094470@svn.freebsd.org> <CAF6rxg=iqSGrFK3Ug0Hzh6nRGnzUA5-Ug_aXrGs4xybBPAty3A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--HsYKTmaHn9HHfM39 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 11, 2013 at 06:33:37PM +0200, Eitan Adler wrote: > On Tue, Jun 11, 2013 at 12:55 PM, Baptiste Daroussin <bapt@freebsd.org> w= rote: > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/devel/tradcpp/files/patch-directive.c Tue Jun 11 10:55:16 201= 3 (r320546) > > + static > > + void > > +-d_line(struct place *p, struct place *p2, char *line) > > ++d_line(struct place *p, struct place *p2 __unused, char *line __unuse= d) > ... > > +-d_pragma(struct place *p, struct place *p2, char *line) > > ++d_pragma(struct place *p, struct place *p2 __unused, char *line) > ... > > +-filter_output(const struct place *p, const char *buf, size_t len) > > ++filter_output(const struct place *p __unused, const char *buf, size_t= len) >=20 >=20 > Perhaps we could build without warnings instead of patching the > source? this would simplify the port and make it more obvious what is > being solved. >=20 >=20 > --=20 > Eitan Adler > Source, Ports, Doc committer > Bugmeister, Ports Security teams No patching is better, has I'm heavily working with upstream on this port. In general disable warning is something I don't like, I prefer to fix them,= and I don't find that complexify the port at all. Bapt --HsYKTmaHn9HHfM39 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlG3UwUACgkQ8kTtMUmk6EwF9wCfUEBPpXlO9/UVyecA+YYqrmp8 wpYAn2PjCzoviSJhICCMyLxa9VnaAcTY =AJxO -----END PGP SIGNATURE----- --HsYKTmaHn9HHfM39--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130611164037.GD35160>