Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Jan 2017 14:37:56 +0000 (UTC)
From:      Jan Beich <jbeich@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r431742 - head/www/webkit-qt4/files
Message-ID:  <201701171437.v0HEbuGv086486@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jbeich
Date: Tue Jan 17 14:37:56 2017
New Revision: 431742
URL: https://svnweb.freebsd.org/changeset/ports/431742

Log:
  www/webkit-qt4: unbreak with clang 4.0
  
  html/HTMLImageElement.cpp:77:24: error: ordered comparison between pointer and zero ('const int *' and 'int')
      if (optionalHeight > 0)
          ~~~~~~~~~~~~~~ ^ ~
  
  PR:		216015
  Regressed by:	https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
  Obtained from:	upstream (excerpt)
  Approved by:	portmgr blanket

Added:
  head/www/webkit-qt4/files/patch-src_3rdparty_webkit_Source_WebCore_html_HTMLImageElement.cpp   (contents, props changed)

Added: head/www/webkit-qt4/files/patch-src_3rdparty_webkit_Source_WebCore_html_HTMLImageElement.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/www/webkit-qt4/files/patch-src_3rdparty_webkit_Source_WebCore_html_HTMLImageElement.cpp	Tue Jan 17 14:37:56 2017	(r431742)
@@ -0,0 +1,21 @@
+------------------------------------------------------------------------
+r113848 | abecsi@webkit.org | 2012-04-11 11:23:19 +0000 (Wed, 11 Apr 2012) | 27 lines
+
+Fix the build with gcc 4.7.0
+https://bugs.webkit.org/show_bug.cgi?id=83584
+[...]
+* html/HTMLImageElement.cpp:
+(WebCore::HTMLImageElement::createForJSConstructor): Fails because of -Werror=extra
+[...]
+
+--- src/3rdparty/webkit/Source/WebCore/html/HTMLImageElement.cpp.orig	2015-05-07 14:14:47 UTC
++++ src/3rdparty/webkit/Source/WebCore/html/HTMLImageElement.cpp
+@@ -74,7 +74,7 @@ PassRefPtr<HTMLImageElement> HTMLImageEl
+     RefPtr<HTMLImageElement> image = adoptRef(new HTMLImageElement(imgTag, document));
+     if (optionalWidth)
+         image->setWidth(*optionalWidth);
+-    if (optionalHeight > 0)
++    if (optionalHeight)
+         image->setHeight(*optionalHeight);
+     return image.release();
+ }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701171437.v0HEbuGv086486>