Date: Tue, 23 Feb 2021 14:06:56 +0100 From: Thomas Vogt <thomas@bsdunix.ch> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Alexey Dokuchaev <danfe@FreeBSD.org>, Li-Wen Hsu <lwhsu@freebsd.org>, michael@fuckner.net, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r540710 - head/sysutils/arcconf Message-ID: <B3D5B01D-22E3-480E-AE49-F631EF6E935C@bsdunix.ch> In-Reply-To: <2c409df4-f4e-dd6a-9688-abae25132de7@pfeifer.com> References: <202006281346.05SDkfaS050010@repo.freebsd.org> <3c213f5-9fb6-c09c-e436-7d4d95619d46@pfeifer.com> <20210203104306.GA8202@FreeBSD.org> <9F1E8D36-EC64-47A6-A453-8442BC819D29@bsdunix.ch> <2c409df4-f4e-dd6a-9688-abae25132de7@pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 23 Feb 2021, at 13:42, Gerald Pfeifer <gerald@pfeifer.com> wrote:
>
> On Wed, 3 Feb 2021, Thomas Vogt wrote:
>>>>> - Update Makefile to use current version of GCC as defined in
>>>>> bsd.default-versions.mk. (USE_GCC=yes)
>>>> ...
>>>>> LIB_DEPENDS= libstdc++.so.6:lang/gcc${GCC_DEFAULT}
>>>>> +USE_GCC= yes
>>>> This looks very (very) odd.
>>>>
>>>> USE_GCC already implies a run-time dependency on lang/gcc${GCC_DEFAULT}
>>>> and I do not recall seeing such a LIB_DEPENDS before.
>>>>
>>>> Are you sure this is really, really needed with USE_GCC=yes?
>>> I believe, seeing NO_BUILD=yes, it's because this is some sort of binary-
>>> only program which links against libstdc++.so.6. I can't verify because
>>> the distfile is ~73MB and that's a bit too much for me to download ATM.
>> arcconf links to libstdc++.so.6. An ancient libstdc++.so.6 version was
>> provided with old freebsd versions (included with an old gcc). The
>> binary failed to run with: ld-elf.so.1: /usr/lib/libstdc++.so.6:
>> version GLIBCXX_3.4.11 required ..
>>
>> Newer gcc versions from the port provided libstdc++.so.6 with >=
>> GLIBCXX_3.4.11. Thats the reason why gcc was added.
>
> So I am wondering: Isn't USE_GCC=yes sufficient?
>
> USE_GCC=yes implies
> RUN_DEPENDS+= ${CC}:lang/gcc${GCC_DEFAULT}
> which pulls in lang/gcc${GCC_DEFAULT} and its run-time libraries at
> run time.
>
> The LIB_DEPENDS statement above does not add to that.
Yes. Maybe RUN_DEPENDS is more obvious than USE_GCC.
Regards,
Tom
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B3D5B01D-22E3-480E-AE49-F631EF6E935C>