Date: Wed, 18 Nov 2015 19:56:21 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r288966 - head/share/mk Message-ID: <564D4865.4050702@FreeBSD.org> In-Reply-To: <15117.1447905199@chaos> References: <201510070032.t970WYvU099368@repo.freebsd.org> <56146B4E.5040401@FreeBSD.org> <24053.1444240925@chaos> <56155FE0.7020809@FreeBSD.org> <564D29A0.6040000@FreeBSD.org> <15117.1447905199@chaos>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/18/15 7:53 PM, Simon J. Gerraty wrote:
> Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>> > As for the actual change in local.autodep.mk, I don't think it is needed
>> > or right since bsd.lib.mk and bsd.prog.mk already do exactly the same
>> > thing via ${OBJS}: ${SRCS:M*.h} if .depend is not yet generated. This
>> > does work in meta mode as I ran into a failure due to it before r291046
>> > (I had removed the libbfd/Makefile.depend.host for other testing). It's
>> > also hooked in far too late and orthogonally to the OBJS in the graph
>> > that need the headers.
> Forgive me; what is "it" in the last sentence?
>
> It is never too late to add a dependency.
> It can easily be too late to add a value to a variable - to affect
> dependencies.
"It" is the header dependency. buildfiles is too late. This would need
to be on OBJS (which bsd.prog.mk/bsd.lib.mk already do, to ensure the
header is part of the object's dependency tree) or beforebuild. Putting
it on buildfiles is a separate part of the dependency tree than the
objects are in.
--
Regards,
Bryan Drewery
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?564D4865.4050702>