From owner-cvs-all Tue Jan 21 21:23:18 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 210A837B401; Tue, 21 Jan 2003 21:23:17 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4734143EB2; Tue, 21 Jan 2003 21:23:16 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.6/8.12.3) with ESMTP id h0M5N81e089537; Tue, 21 Jan 2003 22:23:09 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 21 Jan 2003 22:22:51 -0700 (MST) Message-Id: <20030121.222251.71550060.imp@bsdimp.com> To: nate@root.org Cc: bde@zeta.org.au, alfred@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha busdma_machdep.c src/sys/alpha/osf1 imgact_osf1.c osf1_misc.c src/sys/cam cam_periph.c cam_sim.c cam_xpt.c src/sys/cam/scsi scsi_cd.c scsi_ch.c scsi From: "M. Warner Losh" In-Reply-To: References: <20030122100003.K30758-100000@gamplex.bde.org> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: Nate Lawson writes: : On Wed, 22 Jan 2003, Bruce Evans wrote: : > > On Tue, 21 Jan 2003, Alfred Perlstein wrote: : > > > Log: : > > > Remove M_TRYWAIT/M_WAITOK/M_WAIT. Callers should use 0. : > > > Merge M_NOWAIT/M_DONTWAIT into a single flag M_NOWAIT. : > : > Robert Watson wrote: : > > Hmm. I guess I missed the discussion; I'm a bit behind on mailing lists. : > > To improve code portability and careful thinking by developers, what I'd : > > like to see is something more like the following: M_WAITOK, which : > > explicitly requests sleeping indefinitely, M_NOWAIT, which explicitly : > > requests no sleeping. Rather than a "default" value, a : > : > That's exactly what M_WAITOK was supposed to do. Developers just had to : > think about it since it wasn't really a flag so it was not easy to check : > automatically. : : I like Robert's approach -- keep the flags as they were before but give : M_WAITOK a value other than 0 and deprecate passing in 0 as an arg. This : change only would affect binary kld compat and if 0 only generated a : printf warning (one-shot) but still meant M_WAITOK for a little while, : that would ease the migration. Doing it as a one-shot is useless. "Something is broken" isn't a useful diagnostic. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message