From owner-cvs-src@FreeBSD.ORG Mon Mar 20 07:48:08 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ABE0216A400; Mon, 20 Mar 2006 07:48:08 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57F5D43D58; Mon, 20 Mar 2006 07:48:07 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id k2K7m4Pl086125 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 20 Mar 2006 10:48:04 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id k2K7m4iA086124; Mon, 20 Mar 2006 10:48:04 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 20 Mar 2006 10:48:04 +0300 From: Gleb Smirnoff To: "Christian S.J. Peron" Message-ID: <20060320074804.GC1102@FreeBSD.org> References: <200603182327.k2INRMJR030740@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200603182327.k2INRMJR030740@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2006 07:48:08 -0000 On Sat, Mar 18, 2006 at 11:27:22PM +0000, Christian S.J. Peron wrote: C> csjp 2006-03-18 23:27:22 UTC C> C> FreeBSD src repository C> C> Modified files: C> sys/kern kern_descrip.c C> Log: C> Back out fd optimization introduced in revision 1.280 as it appears to be C> really breaking things. Simple "close(0); dup(fd)" does not return descriptor C> "0" in some cases. Further, this change also breaks some MAC interactions with C> mac_execve_will_transition(). Under certain circumstances, fdcheckstd() can C> be called in execve(2) causing an assertion that checks to make sure that C> stdin, stdout and stderr reside at indexes 0, 1 and 2 in the process fd table C> to fail, resulting in a kernel panic when INVARIANTS is on. C> C> This should also kill the "dup(2) regression on 6.x" show stopper item on the C> 6.1-RELEASE TODO list. C> C> This is a RELENG_6 candidate. C> C> PR: kern/87208 C> Silence from: des C> MFC after: 1 week Thanks, Christian! -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE