Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Jan 2015 18:43:40 -0800
From:      Navdeep Parhar <np@freebsd.org>
To:        Nathan Whitehorn <nwhitehorn@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r277227 - in head/sys: amd64/conf arm/conf conf modules powerpc/conf
Message-ID:  <20150116024340.GA4923@ox>
In-Reply-To: <54B878B7.7050206@freebsd.org>
References:  <201501160139.t0G1dPu5029070@svn.freebsd.org> <54B878B7.7050206@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 15, 2015 at 06:34:31PM -0800, Nathan Whitehorn wrote:
> 
> On 01/15/15 17:39, Navdeep Parhar wrote:
> >Author: np
> >Date: Fri Jan 16 01:39:24 2015
> >New Revision: 277227
> >URL: https://svnweb.freebsd.org/changeset/base/277227
> >
> >Log:
> >   Plug cxgbe(4) back into !powerpc && !arm builds, instead of building it
> >   on amd64 only.
> >
> >Modified:
> >   head/sys/amd64/conf/NOTES
> >   head/sys/arm/conf/NOTES
> >   head/sys/conf/NOTES
> >   head/sys/modules/Makefile
> >   head/sys/powerpc/conf/NOTES
> >
> >
> >
> >Modified: head/sys/modules/Makefile
> >==============================================================================
> >--- head/sys/modules/Makefile	Fri Jan 16 01:32:40 2015	(r277226)
> >+++ head/sys/modules/Makefile	Fri Jan 16 01:39:24 2015	(r277227)
> >@@ -443,7 +443,8 @@ _ti=		ti
> >  _txp=		txp
> >  .endif
> >-.if ${MK_SOURCELESS_UCODE} != "no" && ${MACHINE_CPUARCH} == "amd64"
> >+.if ${MK_SOURCELESS_UCODE} != "no" && ${MACHINE_CPUARCH} != "arm" && \
> >+	${MACHINE_CPUARCH} != "powerpc"
> >  _cxgbe=		cxgbe
> >  .endif
> 
> Don't you want MACHINE_ARCH != powerpc here rather than
> MACHINE_CPUARCH if it builds on powerpc64?
> -Nathan

Hmm, I think you're right.  I'll try building with MACHINE_ARCH and commit if
it succeeds.

Regards,
Navdeep



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150116024340.GA4923>