From owner-freebsd-acpi@FreeBSD.ORG Wed Jun 16 21:14:03 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE83916A4CE for ; Wed, 16 Jun 2004 21:14:03 +0000 (GMT) Received: from caduceus.jf.intel.com (fmr06.intel.com [134.134.136.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id A82FC43D5C for ; Wed, 16 Jun 2004 21:14:03 +0000 (GMT) (envelope-from robert.moore@intel.com) Received: from talaria.jf.intel.com (talaria.jf.intel.com [10.7.209.7]) major-outer.mc,v 1.15 2004/01/30 18:16:28 root Exp $) with ESMTP id i5GLDbF2021159; Wed, 16 Jun 2004 21:13:37 GMT Received: from orsmsxvs041.jf.intel.com (orsmsxvs041.jf.intel.com [192.168.65.54]) major-inner.mc,v 1.10 2004/03/01 19:21:36 root Exp $) with SMTP id i5GL9RmA000357; Wed, 16 Jun 2004 21:09:27 GMT Received: from orsmsx331.amr.corp.intel.com ([192.168.65.56]) M2004061614135230026 ; Wed, 16 Jun 2004 14:13:52 -0700 Received: from orsmsx403.amr.corp.intel.com ([192.168.65.209]) by orsmsx331.amr.corp.intel.com with Microsoft SMTPSVC(6.0.3790.0); Wed, 16 Jun 2004 14:13:52 -0700 x-mimeole: Produced By Microsoft Exchange V6.5.6944.0 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Date: Wed, 16 Jun 2004 14:13:50 -0700 Message-ID: <37F890616C995246BE76B3E6B2DBE055011BA135@orsmsx403.amr.corp.intel.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: apm problem Thread-Index: AcRT5ewWkvmMoYZsQhKINdMBV90A0gAAL++A From: "Moore, Robert" To: "Liam J. Foy" , "M. Warner Losh" X-OriginalArrivalTime: 16 Jun 2004 21:13:52.0157 (UTC) FILETIME=[D30BDCD0:01C453E6] X-Scanned-By: MIMEDefang 2.31 (www . roaringpenguin . com / mimedefang) cc: acpi@freebsd.org Subject: RE: apm problem X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2004 21:14:04 -0000 This entire discussion reminds me why I've always felt that signed integers and system software don't mix. :-) Bob > -----Original Message----- > From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- > acpi@freebsd.org] On Behalf Of Liam J. Foy > Sent: Wednesday, June 16, 2004 1:57 PM > To: M. Warner Losh > Cc: acpi@freebsd.org > Subject: Re: apm problem >=20 > On Wed, 16 Jun 2004 14:52:57 -0600 (MDT) > "M. Warner Losh" wrote: >=20 > > In message: <20040616213946.6f7def3d.liamfoy@sepulcrum.org> > > Liam Foy writes: > > : > +#define APM_UNKNOWN 0xff /* Unknown in APM BIOS spec */ > > : > > : Do you not mean 0xffffffff ? > > > > No. 0xff is the right number here. The problem is that there's a > > number of different flag values, some which come directly from the APM > > BIOS, and others that are generated by the drivers. >=20 > Seems am confused. If they are returning 0xffffffff why are we testing for > 0xff? >=20 > > > > : I agree with the ai_infoversion change above, and from your other > > : mail about changing the number of batteries from 0 to -1. Has nate > > : gave any feedback ? > > > > Not yet. He's recovering from a massive disk crash right now. >=20 > That explains it ;) although he is some what alive. > > > > : I have also made some recent changes which have been commited which > > : have changed the structure of the apm code. I am willing to change > > : the code from >=3D 255 to =3D=3D APM_UNKNOWN if it is decided this = is what > > : the correct way and it is agreeded upon. > > > > I have the changes in my tree, and will work with Nate to get the > > right stuff committed. At the very least the 255's should be changed > > to a meaningful constant. >=20 > Right, keep me informed. >=20 > > > > Warner > _______________________________________________ > freebsd-acpi@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-acpi > To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org"