Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Oct 2001 02:50:52 +0100 (CET)
From:      Cyrille Lefevre <clefevre@citeweb.net>
To:        kuriyama@FreeBSD.org
Cc:        freebsd-ports@FreeBSD.org
Subject:   Re: ports/29858: Updated port: audio/lame (3.89b)
Message-ID:  <200110280150.f9S1oq188022@gits.dyndns.org>
In-Reply-To: <200110271014.f9RAE9B87688@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
kuriyama@FreeBSD.org wrote:
> State-Changed-From-To: open->closed
[snip]
> After talking with Yoshiaki Uchikawa, I decided to commit this PR as
> lame-devel port.  This port will be obsoleted and audio/lame will be
> updated if this version become to see stable.
> 
> I assign you as maintainer of this port.  I modified a little in Makefile
> from your PR.  So please re-submit PR you want more modification to this
> port.

before to submit a new PR, let me ask you some questions :

why did you get rid of PKGNAMESUFFIX=-devel and INSTALLS_SHLIB=yes ?

PKGNAMESUFFIX=-devel make this port distinct from the original one
and avoid namespace conflict when `pkg_add -r lame' is used.

are you sure INSTALLS_SHLIB isn't needed ? my understanding of this
variable is that it is required when ports install shared libraries.

Cyrille.
-- 
Cyrille Lefevre                 mailto:clefevre@citeweb.net

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200110280150.f9S1oq188022>